From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#35062: [PATCH v3 1/3] Remove redundant comparison Date: Sat, 13 Apr 2019 11:06:21 +0300 Message-ID: <835zril476.fsf@gnu.org> References: <1554071761.31929.0@yandex.ru> <20190407021331.948-1-Hi-Angel@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46222"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 35062@debbugs.gnu.org To: Konstantin Kharlamov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 13 10:07:13 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hFDgv-000Bvo-Bx for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 10:07:13 +0200 Original-Received: from localhost ([127.0.0.1]:48276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFDgt-0000wM-W1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 13 Apr 2019 04:07:12 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFDgo-0000wG-1X for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 04:07:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hFDgn-0001oD-1a for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 04:07:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hFDgk-0001n9-NW for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 04:07:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hFDgk-0005x7-ES for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2019 04:07:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2019 08:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35062 X-GNU-PR-Package: emacs Original-Received: via spool by 35062-submit@debbugs.gnu.org id=B35062.155514280422853 (code B ref 35062); Sat, 13 Apr 2019 08:07:02 +0000 Original-Received: (at 35062) by debbugs.gnu.org; 13 Apr 2019 08:06:44 +0000 Original-Received: from localhost ([127.0.0.1]:57779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFDgS-0005wW-FD for submit@debbugs.gnu.org; Sat, 13 Apr 2019 04:06:44 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hFDgQ-0005wA-Uf for 35062@debbugs.gnu.org; Sat, 13 Apr 2019 04:06:43 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:49006) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hFDgL-0001Xd-IM; Sat, 13 Apr 2019 04:06:37 -0400 Original-Received: from [176.228.60.248] (port=3171 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hFDgK-0006ee-71; Sat, 13 Apr 2019 04:06:37 -0400 In-reply-to: <20190407021331.948-1-Hi-Angel@yandex.ru> (message from Konstantin Kharlamov on Sun, 7 Apr 2019 05:13:29 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157573 Archived-At: > From: Konstantin Kharlamov > Date: Sun, 7 Apr 2019 05:13:29 +0300 > > * src/xterm.c (x_set_frame_alpha): due to preceding checks it is bound > to be 0 ≤ alpha ≤ 1. (Bug#35062) > --- > v3: mention functions changed in commit messages, mention the bug > number, and don't mention that it fixes a warning since intention of > changes is clear either way. Thanks, I pushed a slightly different change along the same lines. A minor nit: please avoid using non-ASCII characters in log entries, if that can be avoided, to cater to terminals that don't support UTF-8 (the character you used is not in Latin-1).