From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#31138: Native json slower than json.el Date: Wed, 24 Apr 2019 19:21:37 +0300 Message-ID: <835zr32x2m.fsf@gnu.org> References: <87sh806xwa.fsf@chapu.is> <83d0lmgez2.fsf@gnu.org> <7d503be9-4d85-3d0b-6829-631ad376ba3d@yandex.ru> <831s22gcci.fsf@gnu.org> <83y349gasn.fsf@gnu.org> <83d0lfag4x.fsf@gnu.org> <5cf45a21-65c3-67ee-f123-be83a6ee7c99@yandex.ru> <83a7gjaen6.fsf@gnu.org> <83ftqa8qsg.fsf@gnu.org> <83muki6y6r.fsf@gnu.org> <4b8c6799-e845-768b-749c-f2a883ab89f8@yandex.ru> <83h8aq6v6a.fsf@gnu.org> <834l6q6ozn.fsf@gnu.org> <83zhoi59ao.fsf@gnu.org> <83wojm57sl.fsf@gnu.org> <83ftq96azk.fsf@gnu.org> <83wojk534g.fsf@gnu.org> <6308ceff-479b-2ce7-2072-41e683978c7c@yandex.ru> <83h8ao4vl0.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="94456"; mail-complaints-to="usenet@blaine.gmane.org" Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 24 18:30:23 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJKmo-000OM5-4C for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 18:30:18 +0200 Original-Received: from localhost ([127.0.0.1]:44253 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJKmn-0004uQ-3x for geb-bug-gnu-emacs@m.gmane.org; Wed, 24 Apr 2019 12:30:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:43301) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJKmd-0004k9-MI for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 12:30:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJKep-0005jI-2B for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 12:22:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42770) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJKeo-0005gs-Tr for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 12:22:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJKeo-0000Dg-GI for bug-gnu-emacs@gnu.org; Wed, 24 Apr 2019 12:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Apr 2019 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 31138-submit@debbugs.gnu.org id=B31138.1556122910826 (code B ref 31138); Wed, 24 Apr 2019 16:22:02 +0000 Original-Received: (at 31138) by debbugs.gnu.org; 24 Apr 2019 16:21:50 +0000 Original-Received: from localhost ([127.0.0.1]:56314 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJKeb-0000DG-VG for submit@debbugs.gnu.org; Wed, 24 Apr 2019 12:21:50 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:55394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hJKea-0000D4-AF for 31138@debbugs.gnu.org; Wed, 24 Apr 2019 12:21:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:60346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJKeU-0004hF-8o; Wed, 24 Apr 2019 12:21:42 -0400 Original-Received: from [176.228.60.248] (port=1860 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hJKeT-0005tA-LN; Wed, 24 Apr 2019 12:21:42 -0400 In-reply-to: (message from Dmitry Gutov on Wed, 24 Apr 2019 18:55:45 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158188 Archived-At: > From: Dmitry Gutov > Cc: sebastien@chapu.is, yyoncho@gmail.com, 31138@debbugs.gnu.org > Date: Wed, 24 Apr 2019 18:55:45 +0300 > > On 23.04.2019 17:58, Eli Zaretskii wrote: > > >> Doing that for buffer text as well might be helpful. > > > > In what use cases would this be helpful? Most cases of decoding text > > in a buffer happen when we read text from files, where we already have > > an internal optimization for plain ASCII files. > > HTTP request response buffers? They can be as large as several > megabytes, as we have established in this discussion. Please point me to examples of this, I don't think I understand what you have in mind. > > We could perhaps try > > a similar optimization for UTF-8 instead of just ASCII. > > I think so. Turns out we already do, I just missed that. > But it did increase the performance of json-serialize, by more than 2x, > on the same test data I've been using. > > Like 3.8s to 1.6s for 10 iterations. > > Can we do something like that? Removing conversion altogether is > probably not an option, but even using Fstring_as_unibyte instead lead > to a significant improvement (2,43s with this approach). What does libjansson do if it receives strings with bytes it cannot interpret? Like raw bytes or UTF-8 sequences whose length is more than 4 bytes?