From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24201: 25.1.50; TLS connections sometimes hang Date: Thu, 04 Jul 2019 22:05:15 +0300 Message-ID: <835zohboyc.fsf@gnu.org> References: <87efrp2qw0.fsf@mouse> <83tw0lxjt3.fsf@gnu.org> <6e9f3b6c-43df-bf95-d346-56c93c61b4d7@cs.ucla.edu> <83o9kk96ez.fsf@gnu.org> <83h8qc92hc.fsf@gnu.org> <834l4en63b.fsf@gnu.org> <83h88cjoiv.fsf@gnu.org> <87ftntkc53.fsf@tcd.ie> <83sgrthih6.fsf@gnu.org> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249997"; mail-complaints-to="usenet@blaine.gmane.org" Cc: contovob@tcd.ie, 24201@debbugs.gnu.org, eggert@cs.ucla.edu To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 04 21:19:00 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hj7Fy-0012f7-PL for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jul 2019 21:18:58 +0200 Original-Received: from localhost ([::1]:48286 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj73v-0004xq-Ru for geb-bug-gnu-emacs@m.gmane.org; Thu, 04 Jul 2019 15:06:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36121) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hj73U-0004xd-Vi for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 15:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hj73S-0007uU-UQ for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 15:06:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43070) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hj73S-0007uJ-KV for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 15:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hj73S-00047c-EL for bug-gnu-emacs@gnu.org; Thu, 04 Jul 2019 15:06:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 04 Jul 2019 19:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24201 X-GNU-PR-Package: emacs Original-Received: via spool by 24201-submit@debbugs.gnu.org id=B24201.156226713615809 (code B ref 24201); Thu, 04 Jul 2019 19:06:02 +0000 Original-Received: (at 24201) by debbugs.gnu.org; 4 Jul 2019 19:05:36 +0000 Original-Received: from localhost ([127.0.0.1]:51891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj732-00046u-Bm for submit@debbugs.gnu.org; Thu, 04 Jul 2019 15:05:36 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hj730-00046g-Jh for 24201@debbugs.gnu.org; Thu, 04 Jul 2019 15:05:35 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hj72u-0007Wk-Un; Thu, 04 Jul 2019 15:05:28 -0400 Original-Received: from [176.228.60.248] (port=4061 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hj72r-0005y2-9m; Thu, 04 Jul 2019 15:05:28 -0400 In-reply-to: (message from Lars Ingebrigtsen on Thu, 04 Jul 2019 15:04:54 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:162074 Archived-At: > From: Lars Ingebrigtsen > Cc: "Basil L. Contovounesios" , 24201@debbugs.gnu.org, eggert@cs.ucla.edu > Date: Thu, 04 Jul 2019 15:04:54 +0200 > > With the following patch, connection never hangs: > > diff --git a/lisp/net/network-stream.el b/lisp/net/network-stream.el > index 2b3292b71b..cdb33a59f1 100644 > --- a/lisp/net/network-stream.el > +++ b/lisp/net/network-stream.el > @@ -376,7 +376,7 @@ network-stream-get-response > (goto-char start) > (while (and (memq (process-status stream) '(open run)) > (not (re-search-forward end-of-command nil t))) > - (accept-process-output stream 0.05) > + (accept-process-output stream 0.05 nil t) > (goto-char start)) > ;; Return the data we got back, or nil if the process died. > (unless (= start (point)) Does this mean you have other process objects active at that time? > It's the JUST-THIS-ONE parameter: If that's non-nil, then > accept-process-output returns after the timeout... and we get the data. I don't understand: accept-process-output is supposed to hit the timeout only when there's no data. But you say "and we get the data". So what am I missing here?