From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 37120@debbugs.gnu.org
Subject: bug#37120: [PATCH] Prefer display-line-numbers over linum in docs and custom
Date: Tue, 20 Aug 2019 20:58:44 +0300 [thread overview]
Message-ID: <835zmrlnvv.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmnxFvHtT=sPRBEz4fBTx_BpP2m3T6S4r1SHY5pBeF1FXg@mail.gmail.com> (message from Stefan Kangas on Tue, 20 Aug 2019 19:26:02 +0200)
> From: Stefan Kangas <stefan@marxist.se>
> Date: Tue, 20 Aug 2019 19:26:02 +0200
>
> NEWS.26 says:
>
> 'linum-mode' and all similar packages are henceforth becoming obsolete.
> Users and developers are encouraged to switch to this new feature
> [i.e. display-line-numbers-mode] instead.
>
> This patch updates the FAQ to recommend display-line-numbers-mode over
> linum-mode. It also changes one defcustom in progmodes in the same
> way.
Thanks, but see the comments below.
> WDYT? And, if it looks good, should it go to the master branch or emacs-26?
It should go to master.
> PS. I'm not sure if linum.el should also be moved into lisp/obsolete/
> or if that's premature for 27.1.
I think it's still premature.
> --- a/doc/misc/efaq.texi
> +++ b/doc/misc/efaq.texi
> @@ -1687,7 +1687,7 @@ Displaying the current line or column
> this variable.
>
> @cindex Set number capability in @code{vi} emulators
> -The @samp{linum} package (distributed with Emacs since version 23.1)
> +@samp{display-line-numbers-mode} (added to Emacs in version 26.1)
> displays line numbers in the left margin, like the ``set number''
> capability of @code{vi}. The packages @samp{setnu} and
This is incorrect: display-line-numbers-mode doesn't use the display
margin (linum.el did).
> @samp{wb-line-number} (not distributed with Emacs) also implement this
> diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el
> index cb39e62265..8d3513bad3 100644
> --- a/lisp/progmodes/prog-mode.el
> +++ b/lisp/progmodes/prog-mode.el
> @@ -39,7 +39,8 @@ prog-mode
> (defcustom prog-mode-hook nil
> "Normal hook run when entering programming modes."
> :type 'hook
> - :options '(flyspell-prog-mode abbrev-mode flymake-mode linum-mode
> + :options '(flyspell-prog-mode abbrev-mode flymake-mode
> + display-line-numbers-mode
> prettify-symbols-mode)
Hmm... is it reasonable to run prog-mode-hook just because someone
turns on line numbers? It sounds too drastic to me.
next prev parent reply other threads:[~2019-08-20 17:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 17:26 bug#37120: [PATCH] Prefer display-line-numbers over linum in docs and custom Stefan Kangas
2019-08-20 17:58 ` Eli Zaretskii [this message]
2019-08-20 18:18 ` Stefan Kangas
2019-08-21 16:48 ` Eli Zaretskii
2019-08-22 12:29 ` Stefan Kangas
2019-08-22 13:19 ` Robert Pluim
2019-08-22 13:27 ` Stefan Kangas
2019-08-24 6:54 ` Eli Zaretskii
2019-08-27 0:45 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zmrlnvv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37120@debbugs.gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).