From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#24694: Document url--allow-chars for external use? Date: Sat, 12 Oct 2019 12:11:47 +0300 Message-ID: <835zkunx9o.fsf@gnu.org> References: <8337jy4uv3.fsf@gnu.org> <87oa0vtk3y.fsf@topbug.net> <7137f36f-983f-2e78-ebdc-4b2e277410a1@topbug.net> <83r23jpidw.fsf@gnu.org> <6b6be3c2-9e52-7899-df83-d82611029aee@topbug.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="249746"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 24694@debbugs.gnu.org, rpluim@gmail.com To: Hong Xu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 12 11:13:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iJDSY-0012qY-U0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Oct 2019 11:13:11 +0200 Original-Received: from localhost ([::1]:59676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJDSX-0004iA-Mt for geb-bug-gnu-emacs@m.gmane.org; Sat, 12 Oct 2019 05:13:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58359) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iJDSR-0004hz-Km for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2019 05:13:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iJDSQ-0007Ao-Ma for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2019 05:13:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:51917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iJDSQ-0007Ag-Jt for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2019 05:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iJDSQ-0003iP-DW for bug-gnu-emacs@gnu.org; Sat, 12 Oct 2019 05:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Oct 2019 09:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24694 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 24694-submit@debbugs.gnu.org id=B24694.157087152514214 (code B ref 24694); Sat, 12 Oct 2019 09:13:02 +0000 Original-Received: (at 24694) by debbugs.gnu.org; 12 Oct 2019 09:12:05 +0000 Original-Received: from localhost ([127.0.0.1]:60738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJDRU-0003hB-Ss for submit@debbugs.gnu.org; Sat, 12 Oct 2019 05:12:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iJDRT-0003gh-GJ for 24694@debbugs.gnu.org; Sat, 12 Oct 2019 05:12:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iJDRO-0006r1-9Q; Sat, 12 Oct 2019 05:11:58 -0400 Original-Received: from [176.228.60.248] (port=4617 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iJDRN-0007x0-8F; Sat, 12 Oct 2019 05:11:57 -0400 In-reply-to: <6b6be3c2-9e52-7899-df83-d82611029aee@topbug.net> (message from Hong Xu on Fri, 11 Oct 2019 19:21:34 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169039 Archived-At: > Cc: 24694@debbugs.gnu.org > From: Hong Xu > Date: Fri, 11 Oct 2019 19:21:34 -0700 > > Thanks, I've updated the patch as attached. I have a couple of minor comments: > * url-util.el (url-hexify-string): Accept a list of allowed chars. > * url.texi (URI Encoding): Update url-hexify-string doc and index > improvements. The log message should specify each file with leading directories starting from the root of the Emacs tree. E.g., url-util.el should be shown as lisp/url/url-util.el. Also, please always mention the bug number in the log message. These and other stylistic issues are described in detail in CONTRIBUTE. > +allowed characters. Otherwise, ALLOWED-CHARS should be either a > +vector whose Nth element is non-nil if character N is allowed or > +a list of allowed chars. ^ Please insert a comma where indicated, it will make the sentence easier to read. Thanks.