From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37806: 27.0.50; Need to "extend" face-remap.el Date: Sat, 19 Oct 2019 20:33:33 +0300 Message-ID: <835zkk7i8i.fsf@gnu.org> References: <875zkmmn4u.fsf@gmx.net> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="253689"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37806@debbugs.gnu.org To: Stephen Berman , Ergus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Oct 19 19:34:12 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iLscE-0013qw-U8 for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 19:34:11 +0200 Original-Received: from localhost ([::1]:60520 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLscD-0004TK-6q for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Oct 2019 13:34:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58405) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iLsc7-0004T7-A7 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 13:34:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iLsc6-0000eF-3E for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 13:34:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44691) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iLsc6-0000dp-02 for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 13:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iLsc5-0003ul-Qb for bug-gnu-emacs@gnu.org; Sat, 19 Oct 2019 13:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Oct 2019 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37806 X-GNU-PR-Package: emacs Original-Received: via spool by 37806-submit@debbugs.gnu.org id=B37806.157150643215021 (code B ref 37806); Sat, 19 Oct 2019 17:34:01 +0000 Original-Received: (at 37806) by debbugs.gnu.org; 19 Oct 2019 17:33:52 +0000 Original-Received: from localhost ([127.0.0.1]:53512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLsbv-0003uA-Ay for submit@debbugs.gnu.org; Sat, 19 Oct 2019 13:33:52 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iLsbu-0003ty-0E for 37806@debbugs.gnu.org; Sat, 19 Oct 2019 13:33:50 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:38383) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iLsbo-0000ML-Kd; Sat, 19 Oct 2019 13:33:44 -0400 Original-Received: from [176.228.60.248] (port=2230 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iLsbn-0002mK-RN; Sat, 19 Oct 2019 13:33:44 -0400 In-reply-to: <875zkmmn4u.fsf@gmx.net> (message from Stephen Berman on Fri, 18 Oct 2019 11:14:09 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:169749 Archived-At: > From: Stephen Berman > Date: Fri, 18 Oct 2019 11:14:09 +0200 > > 0. emacs -Q > 1. C-x C-+ (i.e. M-x text-scale-adjust) > 2. M-x variable-pitch-mode or M-x buffer-face-mode > => Args out of range: [nil :family :foundry :swidth :height :weight :slant :underline :inverse :foreground ...], 19 > > The error happens because the vector of face attributes defined in > face-remap.el is missing the recently added :extend attribute, so it is > too short. This also breaks the MELPA package charmap.el (that's where > I hit the error). The patch below fixes this, though perhaps now would > be a good time to do what the comment above the definition of the vector > says: "This variable should probably be defined in C code where the > actual definitions are available." Or is this simple fix good enough? > > (The vector is also missing the :distant-foreground attribute, so the > patch adds that as well. This absence happened to be innocuous because > the first element of the vector is nil, in order to make the attribute > indices match those of the enum lface_attribute_index defined in > dispextern.h, so the vector was long enough; but after the addition of > the :extend attribute, it wasn't anymore (only the indices of the vector > are used in face-remap.el).) > > In GNU Emacs 27.0.50 (build 17, x86_64-pc-linux-gnu, GTK+ Version 3.24.5, cairo version 1.16.0) > of 2019-10-18 built on strobe-lfs84 > Repository revision: 2d13a3f68d4724af52e47675bedf60709c7b5171 > Repository branch: master > Windowing system distributor 'The X.Org Foundation', version 11.0.12003000 > System Description: Linux From Scratch > > > diff --git a/lisp/face-remap.el b/lisp/face-remap.el > index 5cdecb92ee..8e565264fe 100644 > --- a/lisp/face-remap.el > +++ b/lisp/face-remap.el > @@ -69,7 +69,7 @@ internal-lisp-face-attributes > [nil > :family :foundry :swidth :height :weight :slant :underline :inverse > :foreground :background :stipple :overline :strike :box > - :font :inherit :fontset :vector]) > + :font :inherit :fontset :distant :extend :vector]) > > (defun face-attrs-more-relative-p (attrs1 attrs2) > "Return true if ATTRS1 contains a greater number of relative Thanks. Jimmy, could you please take a look?