From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#37774: 27.0.50; new :extend attribute broke visuals of all themes and other packages Date: Thu, 05 Dec 2019 17:47:29 +0200 Message-ID: <835ziuixke.fsf@gnu.org> References: <87o8xwrjba.fsf@bernoul.li> <834kzooo8e.fsf@gnu.org> <877e4d7yzf.fsf@bernoul.li> <83imnvg53q.fsf@gnu.org> <87zhh2ofc9.fsf@bernoul.li> <87k186nsku.fsf@bernoul.li> <87imna18nc.fsf@mail.linkov.net> <42c596c2-b5c1-9fc9-4b92-9c13b386d93d@yandex.ru> <83pnhgrlni.fsf@gnu.org> <83ftiasfdm.fsf@gnu.org> <83lfrulmva.fsf@gnu.org> <76a012f5-8cdd-75d5-322e-a453a612c655@yandex.ru> <83immxjs6q.fsf@gnu.org> <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="53152"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 37774@debbugs.gnu.org, juri@linkov.net To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 05 16:59:39 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ictXW-000DhQ-Pp for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 16:59:38 +0100 Original-Received: from localhost ([::1]:56758 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ictXV-0004jJ-GR for geb-bug-gnu-emacs@m.gmane.org; Thu, 05 Dec 2019 10:59:37 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58448) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ictMJ-0003fX-V8 for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:48:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ictMI-0005rw-TA for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39074) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ictMI-0005qy-Mt for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ictMI-0001uI-He for bug-gnu-emacs@gnu.org; Thu, 05 Dec 2019 10:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Dec 2019 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37774 X-GNU-PR-Package: emacs Original-Received: via spool by 37774-submit@debbugs.gnu.org id=B37774.15755608647307 (code B ref 37774); Thu, 05 Dec 2019 15:48:02 +0000 Original-Received: (at 37774) by debbugs.gnu.org; 5 Dec 2019 15:47:44 +0000 Original-Received: from localhost ([127.0.0.1]:45047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ictLz-0001tn-Tg for submit@debbugs.gnu.org; Thu, 05 Dec 2019 10:47:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ictLx-0001tX-Ii for 37774@debbugs.gnu.org; Thu, 05 Dec 2019 10:47:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:41714) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ictLq-0005G0-Hw; Thu, 05 Dec 2019 10:47:34 -0500 Original-Received: from [176.228.60.248] (port=2224 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ictLp-0005W1-Gf; Thu, 05 Dec 2019 10:47:34 -0500 In-reply-to: <993b2f9c-6052-e791-3d3b-26d5fedd7d12@yandex.ru> (message from Dmitry Gutov on Thu, 5 Dec 2019 03:44:22 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172917 Archived-At: > Cc: 37774@debbugs.gnu.org, juri@linkov.net > From: Dmitry Gutov > Date: Thu, 5 Dec 2019 03:44:22 +0200 > > The new definition for diff-added would look like: > > (defface diff-added > '((default > :inherit diff-changed) > (((class color) (min-colors 257) (background light)) > :background "#eeffee") > (((class color) (min-colors 88) (background light)) > :background "#ddffdd") > (((class color) (min-colors 88) (background dark)) > :background "#335533") > (((class color)) > :foreground "green")) > "`diff-mode' face used to highlight added lines.") > > (put 'diff-added 'face-transient-spec '((t :extend t))) OK, and how will this work to countermand the problem with themes? custom-theme-set-faces calls face-spec-set, which calls face-spec-recalc, which starts by resetting all face attributes to 'unspecified'. And the last 2 functions are general-purpose, not specific to themes.