unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 37820@debbugs.gnu.org, shouman@comcast.net
Subject: bug#37820: 25.2; xref using etags incorrect case fold during completion
Date: Fri, 17 Jan 2020 10:28:23 +0200	[thread overview]
Message-ID: <835zha32s8.fsf@gnu.org> (raw)
In-Reply-To: <abb85c0d-b89d-d82a-836e-f1e2755fa149@yandex.ru> (message from Dmitry Gutov on Fri, 17 Jan 2020 04:15:07 +0300)

> Cc: 37820@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Fri, 17 Jan 2020 04:15:07 +0300
> 
> Eli, is this patch okay for emacs-27?
> 
> On the one hand, the issue seems minor-ish.
> 
> On the other, it's a backward compatibility problem. And the patch must 
> be pretty safe because it's basically additive: the only real change is 
> to xref--read-identifier, and it calls 
> xref-backend-identifier-completion-ignore-case which will default to the 
> current behavior for all backends except etags.

Can you tell what is the difference in user-facing behavior due to
this change?  I'm not sure I understand that looking at the patch.

Thanks.





  parent reply	other threads:[~2020-01-17  8:28 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19  0:13 bug#37820: 25.2; xref using etags incorrect case fold during completion Radey Shouman
2019-10-19  6:53 ` Eli Zaretskii
2019-10-19  7:14   ` Dmitry Gutov
2019-10-19 17:40     ` Radey Shouman
2019-10-25 13:59     ` Radey Shouman
2019-12-25  0:45       ` Dmitry Gutov
2019-12-26 20:56         ` Radey Shouman
     [not found]           ` <abb85c0d-b89d-d82a-836e-f1e2755fa149@yandex.ru>
2020-01-17  8:28             ` Eli Zaretskii [this message]
2020-01-17 12:49               ` Dmitry Gutov
2020-01-17 13:39                 ` Eli Zaretskii
2020-01-17 21:29                   ` Dmitry Gutov
2020-01-17 15:34                 ` Radey Shouman
2020-01-17 21:28                   ` Dmitry Gutov
2020-01-18 22:33                     ` Radey Shouman
2019-10-19 17:34   ` Radey Shouman
2019-10-19 21:07     ` Drew Adams
2019-10-20 16:19     ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835zha32s8.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=37820@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=shouman@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).