From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: stefan@marxist.se, michael.albinus@gmx.de, 37527@debbugs.gnu.org
Subject: bug#37527: [PATCH] Install C source code for for debugging help
Date: Sat, 25 Jan 2020 09:58:42 +0200 [thread overview]
Message-ID: <835zh0q85p.fsf@gnu.org> (raw)
In-Reply-To: <b47b0542-73f4-5f0c-67fe-6b0333059122@cs.ucla.edu> (message from Paul Eggert on Fri, 24 Jan 2020 16:47:49 -0800)
> Cc: stefan@marxist.se, michael.albinus@gmx.de, rgm@gnu.org,
> 37527-done@debbugs.gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 24 Jan 2020 16:47:49 -0800
>
> OK, I did it that way by installing the attached patch instead; the new
> separate variable is 'emacs-source-directory'.
Thanks, but the name of this variable gives no clue about the sources
being installed as part of "make install", and neither does its
documentation. How about emacs-installed-source-directory?
> +DEBUGGING AN INSTALLED EMACS
> +
> +* Installed Emacs source code
> +
> +Emacs installs a compressed copy of much of its source code, to make
"optionally installs", right? This is an opt-in feature, right?
> @@ -374,6 +377,7 @@ epaths-force:
> -e 's;\(#.*PATH_BITMAPS\).*$$;\1 "${bitmapdir}";' \
> -e 's;\(#.*PATH_X_DEFAULTS\).*$$;\1 "${x_default_search_path}";' \
> -e 's;\(#.*PATH_GAME\).*$$;\1 $(PATH_GAME);' \
> + -e 's;\(#.*PATH_EMACS_SOURCE\).*$$;\1 "${emacs_srcdir}";' \
> -e 's;\(#.*PATH_DOC\).*$$;\1 "${etcdocdir}";') && \
> ${srcdir}/build-aux/move-if-change epaths.h.$$$$ src/epaths.h
The epath-force-w32 part needs a similar change.
> +AC_ARG_ENABLE([install-srcdir],
> + [AS_HELP_STRING([--disable-install-srcdir],
> + [do not install low-level Emacs source code useful for debugging.])],
I don't think we agreed to make this on by default, did we?
> +** The new variable 'emacs-source-directory' gives the Emacs source
> +code location.
This should explain that this is a copy of the sources, different
from the original source tree where Emacs was built.
> (defvar find-function-C-source-directory
> - (let ((dir (expand-file-name "src" source-directory)))
> - (if (file-accessible-directory-p dir) dir))
> + (let ((dir (expand-file-name "src" emacs-source-directory)))
> + (if (file-accessible-directory-p dir) dir
> + (setq dir (expand-file-name "src" source-directory))
> + (if (file-accessible-directory-p dir) dir)))
This is backwards, IMO: it should first try the original source tree,
and only next the installed sources.
next prev parent reply other threads:[~2020-01-25 7:58 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 20:07 bug#37527: [PATCH] Install C source code for for debugging help Paul Eggert
2019-09-27 5:09 ` Eli Zaretskii
2019-09-27 6:24 ` Paul Eggert
2019-09-27 7:21 ` Eli Zaretskii
2019-09-27 8:48 ` Andreas Schwab
2019-09-27 8:58 ` Michael Albinus
2019-09-27 11:36 ` Eli Zaretskii
2019-09-27 19:59 ` Michael Albinus
2019-09-28 5:55 ` Paul Eggert
2019-09-28 7:29 ` Eli Zaretskii
2019-09-28 7:54 ` Michael Albinus
2019-09-29 7:09 ` Paul Eggert
2019-09-28 6:01 ` Eli Zaretskii
2019-09-28 9:11 ` Michael Albinus
2019-09-28 9:43 ` Eli Zaretskii
2019-10-03 13:38 ` Michael Albinus
2019-10-03 16:26 ` Eli Zaretskii
2019-10-04 8:52 ` Michael Albinus
2019-10-03 16:54 ` Basil L. Contovounesios
2019-10-04 8:54 ` Michael Albinus
2019-10-03 21:50 ` Paul Eggert
2019-10-03 22:32 ` Glenn Morris
2019-10-04 1:28 ` Paul Eggert
2019-10-04 8:57 ` Michael Albinus
2019-10-04 9:20 ` Michael Albinus
2019-10-06 7:48 ` Paul Eggert
2019-10-07 15:17 ` Michael Albinus
2019-10-07 19:48 ` Paul Eggert
2019-10-08 7:47 ` Eli Zaretskii
2019-10-08 9:54 ` Michael Albinus
2019-10-08 11:58 ` Eli Zaretskii
2020-01-20 19:12 ` Stefan Kangas
2020-01-21 9:13 ` Paul Eggert
2020-01-21 17:02 ` Eli Zaretskii
2020-01-21 17:48 ` Paul Eggert
2020-01-21 18:04 ` Eli Zaretskii
2020-01-22 0:27 ` Paul Eggert
2020-01-22 3:31 ` Eli Zaretskii
2020-01-23 8:58 ` Paul Eggert
2020-01-23 14:23 ` Eli Zaretskii
2020-01-23 17:42 ` Paul Eggert
2020-01-23 18:24 ` Eli Zaretskii
2020-01-25 0:47 ` Paul Eggert
2020-01-25 7:58 ` Eli Zaretskii [this message]
2020-01-26 9:00 ` Paul Eggert
2020-01-26 16:13 ` Eli Zaretskii
2020-01-26 18:18 ` Paul Eggert
2020-01-26 19:24 ` Eli Zaretskii
2020-01-26 20:09 ` Michael Albinus
2020-01-27 21:17 ` Paul Eggert
2020-01-28 3:22 ` Eli Zaretskii
2020-01-26 20:06 ` Michael Albinus
2020-01-26 20:10 ` Eli Zaretskii
2019-09-28 5:51 ` Paul Eggert
2019-09-29 13:02 ` Rohan Hendrik Jotz-Lean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835zh0q85p.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=37527@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=michael.albinus@gmx.de \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).