unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: etimmons@mit.edu, 38867@debbugs.gnu.org
Subject: bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced
Date: Tue, 24 Mar 2020 16:08:28 +0200	[thread overview]
Message-ID: <835zetc0bn.fsf@gnu.org> (raw)
In-Reply-To: <87a746jcnu.fsf@gmail.com> (message from Noam Postavsky on Tue, 24 Mar 2020 06:00:05 -0400)

> From: Noam Postavsky <npostavs@gmail.com>
> Date: Tue, 24 Mar 2020 06:00:05 -0400
> Cc: 38867@debbugs.gnu.org
> 
> > Fix by telling `perform-replace' to operate over the entire
> > buffer. Could potentially be further be optimized by saving the point
> > in the scan-function and using it as the start point in the
> > operate-function.
> 
> Since the current code is trying to save the point in the scan function,
> it's better to keep that optimization.  See patch below.  Should this go
> to emacs-27 or master?  The assumption that point would be preserved
> seems to be long-standing, but I guess the change in the default of
> switch-to-buffer-preserve-window-point is what surfaces the bug and
> makes it more recent...

I think this can wait for Emacs 28, but if you disagree, please tell
why.

Thanks.





  reply	other threads:[~2020-03-24 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  5:08 bug#38867: 27.0.60; fileloop-initialize-replace misses occurrences to be replaced Eric Michael Timmons
2020-03-24 10:00 ` Noam Postavsky
2020-03-24 14:08   ` Eli Zaretskii [this message]
2020-03-31 22:23     ` Noam Postavsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835zetc0bn.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=38867@debbugs.gnu.org \
    --cc=etimmons@mit.edu \
    --cc=npostavs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).