From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Date: Wed, 17 Jun 2020 19:33:00 +0300 Message-ID: <835zbp1wlf.fsf@gnu.org> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <83968f43-1298-6c5a-b4fa-ba68b7a8042e@yandex.ru> <838sgl22f2.fsf@gnu.org> <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="108256"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41890@debbugs.gnu.org, theo@thornhill.no To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 17 18:34:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlb0t-000S1B-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jun 2020 18:34:11 +0200 Original-Received: from localhost ([::1]:58766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlb0s-0007cW-2f for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jun 2020 12:34:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43366) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlb0k-0007am-DW for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 12:34:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40503) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlb0k-0003xf-3r for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 12:34:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlb0j-0000K3-VM for bug-gnu-emacs@gnu.org; Wed, 17 Jun 2020 12:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Jun 2020 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41890-submit@debbugs.gnu.org id=B41890.15924116061183 (code B ref 41890); Wed, 17 Jun 2020 16:34:01 +0000 Original-Received: (at 41890) by debbugs.gnu.org; 17 Jun 2020 16:33:26 +0000 Original-Received: from localhost ([127.0.0.1]:52049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlb0A-0000J1-JO for submit@debbugs.gnu.org; Wed, 17 Jun 2020 12:33:26 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlb06-0000Ii-Un for 41890@debbugs.gnu.org; Wed, 17 Jun 2020 12:33:25 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:47635) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlb01-0003um-7z; Wed, 17 Jun 2020 12:33:17 -0400 Original-Received: from [176.228.60.248] (port=1243 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jlb00-0004An-19; Wed, 17 Jun 2020 12:33:16 -0400 In-Reply-To: <87489b66-81f2-311d-cd81-9d344731577f@yandex.ru> (message from Dmitry Gutov on Wed, 17 Jun 2020 18:49:47 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182074 Archived-At: > Cc: theo@thornhill.no, 41890@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 17 Jun 2020 18:49:47 +0300 > > On 17.06.2020 17:27, Eli Zaretskii wrote: > > I mean it isn't preloaded, but is loaded on demand. > > Okay, but... the commands in the keymap will all be autoloaded. So > whenever somebody calls them, the aforementioned optional package will > get loaded. I'm not sure what the practical issue with that is. I don't see how this is related to the issue at hand. All I'm saying is that a package, including its key bindings, shouldn't be loaded until some of its feature is invoked. Therefore, the best place for a package's keybindings is in the package itself. What you describe seems to fit this principle. > The issue on the other side (keeping the keymap definition in > project.el) is that it's an ELPA package as well. And so far we've said > that ELPA packages shouldn't significantly modify a user's Emacs just by > the virtue of being installed. We could make the keybindings autoloaded without having them defined them when the package loads, couldn't we? By having the define-key on the same line as the autoload cookie, like bookmark.el does.