From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25542: 25.1; Restoring the frame from fullscreen to maximized Date: Sat, 05 Sep 2020 19:07:53 +0300 Message-ID: <835z8sp5pi.fsf@gnu.org> References: <5889C6B4.8060506@gmx.at> <588A0102.7010704@gmx.at> <588B108E.9070501@gmx.at> <588B1437.9010303@gmx.at> <588B4F7C.40909@gmx.at> <588C5003.4070409@gmx.at> <87r1rhbu2s.fsf@gnus.org> <83wo18pvoh.fsf@gnu.org> <83eengpgdn.fsf@gnu.org> <83d030pfrf.fsf@gnu.org> <5bd82b3a-0108-5dd4-88dd-e3def6b77e01@cornell.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11334"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, dmoncayo@gmail.com, 25542@debbugs.gnu.org, npostavs@users.sourceforge.net To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 18:09:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEakX-0002rV-IN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 18:09:09 +0200 Original-Received: from localhost ([::1]:35646 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEakW-0007k1-Kw for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 12:09:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50062) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEakQ-0007jq-UB for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:09:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60633) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEakQ-0000Jn-Kq for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:09:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEakQ-0005Xr-GI for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 12:09:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 16:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25542 X-GNU-PR-Package: emacs Original-Received: via spool by 25542-submit@debbugs.gnu.org id=B25542.159932209121254 (code B ref 25542); Sat, 05 Sep 2020 16:09:02 +0000 Original-Received: (at 25542) by debbugs.gnu.org; 5 Sep 2020 16:08:11 +0000 Original-Received: from localhost ([127.0.0.1]:43946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaja-0005Wj-Pn for submit@debbugs.gnu.org; Sat, 05 Sep 2020 12:08:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:39848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEajZ-0005WX-6c for 25542@debbugs.gnu.org; Sat, 05 Sep 2020 12:08:09 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35710) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEajS-0000GA-VP; Sat, 05 Sep 2020 12:08:02 -0400 Original-Received: from [176.228.60.248] (port=4422 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kEajS-00053u-AW; Sat, 05 Sep 2020 12:08:02 -0400 In-Reply-To: <5bd82b3a-0108-5dd4-88dd-e3def6b77e01@cornell.edu> (message from Ken Brown on Sat, 5 Sep 2020 11:10:31 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187275 Archived-At: > Cc: Lars Magne Ingebrigtsen , 25542@debbugs.gnu.org, > Noam Postavsky , > martin rudalics > From: Ken Brown > Date: Sat, 5 Sep 2020 11:10:31 -0400 > > diff --git a/src/w32term.c b/src/w32term.c > index 76cf6bd696..c7da95528b 100644 > --- a/src/w32term.c > +++ b/src/w32term.c > @@ -5454,15 +5454,7 @@ w32_read_socket (struct terminal *terminal, > simple hack to check that based on the fact that > only a maximized fullscreen frame should have both > top/left outside the screen. */ > - if (EQ (fullscreen, Qfullwidth) || EQ (fullscreen, Qfullheight) > - || NILP (fullscreen)) > - { > - int x, y; > - > - w32_real_positions (f, &x, &y); > - if (x < 0 && y < 0) > - store_frame_param (f, Qfullscreen, Qmaximized); > - } > + store_frame_param (f, Qfullscreen, Qmaximized); > } > > break; > > If I make this change and follow Dani's recipe from the original bug report, the > second F11 press doesn't restore the previous state. Instead, the frame appears > to get slightly smaller for an instant and then immediately reverts to > fullscreen mode. Thanks for testing. It sounds like the proposed change leaves the original incorrect behavior unchanged, so we need to look for some different way of fixing this.