From: Eli Zaretskii <eliz@gnu.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 44341@debbugs.gnu.org, thibault@thb.lt, monnier@iro.umontreal.ca
Subject: bug#44341: 27.1; define-minor-mode generates inaccurate docstring
Date: Mon, 02 Nov 2020 17:52:38 +0200 [thread overview]
Message-ID: <835z6neoxl.fsf@gnu.org> (raw)
In-Reply-To: <CAArVCkQQLk0ysD4_i323KTMR5Uc7R-UdJQiLZgt8JUWYn0dmsg@mail.gmail.com> (message from Philipp Stephani on Mon, 2 Nov 2020 13:28:06 +0100)
> From: Philipp Stephani <p.stephani2@gmail.com>
> Date: Mon, 2 Nov 2020 13:28:06 +0100
> Cc: 44341@debbugs.gnu.org, Thibault Polge <thibault@thb.lt>
>
> Am So., 1. Nov. 2020 um 16:30 Uhr schrieb Stefan Monnier
> <monnier@iro.umontreal.ca>:
>
> > > disable ; Should disable (as a random symbol)
> > > disable ; Again
> > > "What?" ; Same.
> >
> > These should be considered as errors. Whether we catch them and signal
> > an error or silently do something else is not particular important
> > to me.
>
> We should definitely signal an error here. A form such as (my-mode
> 'enable) actually disabling the mode is very confusing.
Signaling an error would be an incompatible change. Someone who has
(my-mode 'disable)
in their Lisp code will complain that it makes perfect sense.
I object to making incompatible changes in this area; let's fix the
problems wrt documentation, but it's too late to introduce
incompatible changes into this stuff, which is used all over, in Emacs
and elsewhere. Wed already had the first bug report about such
incompatible changes, less than a day after it was pushed. I'm quite
certain that incompatible change was unintended, but here you propose
to make it quite intentionally, and that would be a serious mistake,
IMO.
next prev parent reply other threads:[~2020-11-02 15:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 11:00 bug#44341: 27.1; define-minor-mode generates inaccurate docstring Thibault Polge
2020-11-01 14:00 ` Lars Ingebrigtsen
2020-11-01 15:29 ` Stefan Monnier
2020-11-02 12:28 ` Philipp Stephani
2020-11-02 15:35 ` Lars Ingebrigtsen
2020-11-02 15:52 ` Eli Zaretskii [this message]
2020-11-02 16:18 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z6neoxl.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=44341@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=p.stephani2@gmail.com \
--cc=thibault@thb.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).