unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Alan Third <alan@idiocy.org>
Cc: 44349@debbugs.gnu.org, p.stephani2@gmail.com
Subject: bug#44349: 28.0.50; Assertion failure on macOS when resizing frame
Date: Sat, 28 Nov 2020 09:51:57 +0200	[thread overview]
Message-ID: <835z5por4y.fsf@gnu.org> (raw)
In-Reply-To: <20201127222429.GD26836@breton.holly.idiocy.org> (message from Alan Third on Fri, 27 Nov 2020 22:24:29 +0000)

> Date: Fri, 27 Nov 2020 22:24:29 +0000
> From: Alan Third <alan@idiocy.org>
> Cc: Philipp Stephani <p.stephani2@gmail.com>, 44349@debbugs.gnu.org
> 
> > I don't see why we would want to enforce that, it sounds like a grave
> > limitation.  Maybe I'm missing some background here.  The version we
> > have on emacs-27 does support non-ASCII characters in the format.
> 
> Patch attached.
> 
> I can't see any other special cases that need to be handled and all my
> tests worked, so I think this is all that's needed.

Thanks!  Can we add tests for this?

> +          /* doprnt_non_null_end doesn't know about multibyte
> +             characters so can truncate format in the middle of one.
> +             If that happens just ignore that character.  */

Is this because the buffer size is measured in characters, not bytes?
Or are there other situations where this could happen?  Can you give
an example?

Silently ignoring parts of input sounds ... unusual, so I wonder what
would it take to avoid that.  How did the old code avoid this problem?





  reply	other threads:[~2020-11-28  7:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 15:51 bug#44349: 28.0.50; Assertion failure on macOS when resizing frame Philipp
2020-10-31 15:57 ` Philipp Stephani
2020-10-31 16:03   ` Philipp Stephani
2020-10-31 16:35   ` Eli Zaretskii
2020-10-31 16:43     ` Philipp Stephani
2020-10-31 16:52       ` Eli Zaretskii
2020-11-27 22:24         ` Alan Third
2020-11-28  7:51           ` Eli Zaretskii [this message]
2020-11-28 22:06             ` Alan Third
2020-11-29 10:27               ` Lars Ingebrigtsen
2020-11-29 15:10               ` Eli Zaretskii
2020-11-29 17:16                 ` Alan Third
2020-11-29 17:23                   ` Eli Zaretskii
2020-11-29 17:43                     ` Alan Third
2020-11-01  0:55   ` Alan Third
2020-11-01  0:58     ` Alan Third
2020-11-01  1:00     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z5por4y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=44349@debbugs.gnu.org \
    --cc=alan@idiocy.org \
    --cc=p.stephani2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).