From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#44349: 28.0.50; Assertion failure on macOS when resizing frame Date: Sun, 29 Nov 2020 17:10:03 +0200 Message-ID: <835z5omc6s.fsf@gnu.org> References: <83eelegxq6.fsf@gnu.org> <83a6w2gwxz.fsf@gnu.org> <20201127222429.GD26836@breton.holly.idiocy.org> <835z5por4y.fsf@gnu.org> <20201128220645.GF26836@breton.holly.idiocy.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22909"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 44349@debbugs.gnu.org, p.stephani2@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 29 16:11:24 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kjOMF-0005qq-Dx for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 16:11:23 +0100 Original-Received: from localhost ([::1]:38996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjOME-0003zg-EB for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Nov 2020 10:11:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kjOLy-0003ys-Gd for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 10:11:07 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kjOLu-0001fQ-6g for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 10:11:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kjOLu-0003x1-0o for bug-gnu-emacs@gnu.org; Sun, 29 Nov 2020 10:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Nov 2020 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44349 X-GNU-PR-Package: emacs Original-Received: via spool by 44349-submit@debbugs.gnu.org id=B44349.160666262515098 (code B ref 44349); Sun, 29 Nov 2020 15:11:01 +0000 Original-Received: (at 44349) by debbugs.gnu.org; 29 Nov 2020 15:10:25 +0000 Original-Received: from localhost ([127.0.0.1]:52230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjOLJ-0003vS-D6 for submit@debbugs.gnu.org; Sun, 29 Nov 2020 10:10:25 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:36016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kjOLG-0003v5-4H for 44349@debbugs.gnu.org; Sun, 29 Nov 2020 10:10:23 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35062) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kjOLA-0001Oq-Su; Sun, 29 Nov 2020 10:10:16 -0500 Original-Received: from [176.228.60.248] (port=1618 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kjOL7-0004Yy-FL; Sun, 29 Nov 2020 10:10:16 -0500 In-Reply-To: <20201128220645.GF26836@breton.holly.idiocy.org> (message from Alan Third on Sat, 28 Nov 2020 22:06:45 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:194557 Archived-At: > Date: Sat, 28 Nov 2020 22:06:45 +0000 > From: Alan Third > Cc: p.stephani2@gmail.com, 44349@debbugs.gnu.org > > > Thanks! Can we add tests for this? > > I was wondering that. How do we add tests for internal C functions? By calling Lisp functions which call them. But maybe it isn't possible in this case. Wait, isn't the use case which caused this bug report a suitable test for the change? > > Silently ignoring parts of input sounds ... unusual, so I wonder what > > would it take to avoid that. How did the old code avoid this problem? > > This situation can only be caused by calling doprnt with format_end > set to some point inside a multibyte character (it's a pointer). Ah, okay. In that case, I think ignoring the invalid sequence is OK, but let's document that in the function's commentary. Thanks.