unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Kangas <stefan@marxist.se>
Cc: 45550@debbugs.gnu.org
Subject: bug#45550: [PATCH] Factor out new function for readability in chartab.c
Date: Thu, 31 Dec 2020 05:29:08 +0200	[thread overview]
Message-ID: <835z4iirgb.fsf@gnu.org> (raw)
In-Reply-To: <CADwFkmn9KeOb=fZzcAoWDhPP8PZ5t7XUNwc_hdjLxcfna0k2_g@mail.gmail.com> (message from Stefan Kangas on Wed, 30 Dec 2020 15:16:05 -0600)

> From: Stefan Kangas <stefan@marxist.se>
> Date: Wed, 30 Dec 2020 15:16:05 -0600
> Cc: 45550@debbugs.gnu.org
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > Please make this a macro, not a function.  The code you are factoring
> > out is called in the innermost loops of the display engine, in bidi.c,
> > so it must be as fast as possible, even in an unoptimized build, where
> > static functions aren't inlined.
> 
> Would it be acceptable to use our INLINE macro here instead?

I'd prefer a simple macro.  I can never remember the exact semantics
of INLINE this week.

Thanks.





  reply	other threads:[~2020-12-31  3:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-30  8:56 bug#45550: [PATCH] Factor out new function for readability in chartab.c Stefan Kangas
2020-12-30 20:15 ` Eli Zaretskii
2020-12-30 21:16   ` Stefan Kangas
2020-12-31  3:29     ` Eli Zaretskii [this message]
2021-07-21 12:03       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835z4iirgb.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=45550@debbugs.gnu.org \
    --cc=stefan@marxist.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).