From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacsuser@freemail.hu, 36970@debbugs.gnu.org
Subject: bug#36970: 26.2; invalid-read-syntax could print the location of the error
Date: Mon, 01 Feb 2021 17:06:59 +0200 [thread overview]
Message-ID: <835z3b7ros.fsf@gnu.org> (raw)
In-Reply-To: <87k0rsrxjs.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 01 Feb 2021 09:40:07 +0100)
> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: emacsuser@freemail.hu, 36970@debbugs.gnu.org
> Date: Mon, 01 Feb 2021 09:40:07 +0100
>
> nlines = display_count_lines (startpos_byte,
> PT_BYTE, PT, &junk);
>
> So I guess I should just put the prototype in lisp.h and use it?
Yes (and make it non-static). Alternatively, define a wrapper for it
that doesn't accept that last arg, and make _that_ wrapper extern and
more suitably named.
> (It's kinda surprising that no other part of Emacs has felt the need
> to compute a line number before...)
Emacs almost never counts lines, except for 2 display features: the
line-number display in the mode line and display-line-numbers-mode.
The buffer-with-gap paradigm makes a point of not knowing where each
line ends and how many lines are there.
next prev parent reply other threads:[~2021-02-01 15:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 8:27 bug#36970: 26.2; invalid-read-syntax could print the location of the error ndame
2021-01-30 7:54 ` Lars Ingebrigtsen
2021-01-31 9:14 ` Lars Ingebrigtsen
2021-01-31 10:15 ` Lars Ingebrigtsen
2021-01-31 14:57 ` Eli Zaretskii
2021-02-01 8:40 ` Lars Ingebrigtsen
2021-02-01 15:06 ` Eli Zaretskii [this message]
2021-02-01 16:10 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835z3b7ros.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=36970@debbugs.gnu.org \
--cc=emacsuser@freemail.hu \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).