From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#48500: 28.0.50; url-retrieve-synchronously exits abnormally due to pending keyboard input from terminal Date: Wed, 19 May 2021 14:57:09 +0300 Message-ID: <835yzfq6lm.fsf@gnu.org> References: <87pmxo4kiu.wl-mullikine@gmail.com> <8335ukrsj3.fsf@gnu.org> <83sg2kq8yc.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6400"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 48500@debbugs.gnu.org To: Shane Mulligan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 19 13:58:23 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ljKqF-0001YF-Ev for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 13:58:23 +0200 Original-Received: from localhost ([::1]:50432 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKqD-0000Pq-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 19 May 2021 07:58:21 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47584) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKpv-0000Pg-3x for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 07:58:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46739) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ljKpt-0002hm-M1 for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 07:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ljKpt-0004wD-LB for bug-gnu-emacs@gnu.org; Wed, 19 May 2021 07:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 May 2021 11:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48500 X-GNU-PR-Package: emacs Original-Received: via spool by 48500-submit@debbugs.gnu.org id=B48500.162142542918909 (code B ref 48500); Wed, 19 May 2021 11:58:01 +0000 Original-Received: (at 48500) by debbugs.gnu.org; 19 May 2021 11:57:09 +0000 Original-Received: from localhost ([127.0.0.1]:58285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljKp3-0004uv-LD for submit@debbugs.gnu.org; Wed, 19 May 2021 07:57:09 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ljKoz-0004u9-0S for 48500@debbugs.gnu.org; Wed, 19 May 2021 07:57:08 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45678) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ljKot-00025C-OC; Wed, 19 May 2021 07:56:59 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3132 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ljKot-0000Uk-9R; Wed, 19 May 2021 07:56:59 -0400 In-Reply-To: (message from Shane Mulligan on Wed, 19 May 2021 18:48:09 +1200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206876 Archived-At: > From: Shane Mulligan > Date: Wed, 19 May 2021 18:48:09 +1200 > > I may have resolved this issue with the following patch to `url-retrieve-synchronously`. > What this achieves is to trigger a `quit` in a controlled environment rather than allowing it to occur when > `accept-process-output` is run. > It's not always wanted to trigger a quit when `(input-pending-p)` is `t`. But I noticed from placing > `while-no-input` around `accept-process-output` to avoid the `quit` that `url-retrieve-synchronously` would > then hang but with the controlled `quit` happening beforehand, `accept-process-output` no longer needs > `while-no-input` around it. The end result is buttery smooth helm with no accidental `quit` from typing too > fast. I think this may have resulted in GUI helm faster too. Thanks, but what causes a quit in the first place?