From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#49632: [PATCH] Ensure that M-x gdb populates gud-repeat-map Date: Mon, 19 Jul 2021 16:13:52 +0300 Message-ID: <835yx678fj.fsf@gnu.org> References: <89178870.2006793.1626665845848@ichabod.co-bxl> <87eebupi5k.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24594"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 49632@debbugs.gnu.org, leungbk@mailfence.com, juri@linkov.net To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jul 19 15:15:14 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m5T73-00069R-4F for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 15:15:13 +0200 Original-Received: from localhost ([::1]:38910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5T71-0002Ub-Uw for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Jul 2021 09:15:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46274) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5T6s-0002SB-Hi for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 09:15:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46785) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1m5T6s-0001qv-8d for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 09:15:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1m5T6s-0002yF-4C for bug-gnu-emacs@gnu.org; Mon, 19 Jul 2021 09:15:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jul 2021 13:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49632 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 49632-submit@debbugs.gnu.org id=B49632.162670046811357 (code B ref 49632); Mon, 19 Jul 2021 13:15:02 +0000 Original-Received: (at 49632) by debbugs.gnu.org; 19 Jul 2021 13:14:28 +0000 Original-Received: from localhost ([127.0.0.1]:58329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5T6J-0002x7-UN for submit@debbugs.gnu.org; Mon, 19 Jul 2021 09:14:28 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1m5T6H-0002wr-Oe for 49632@debbugs.gnu.org; Mon, 19 Jul 2021 09:14:26 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40418) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m5T6A-0001N3-OH; Mon, 19 Jul 2021 09:14:18 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m5T68-0006VH-9f; Mon, 19 Jul 2021 09:14:18 -0400 In-Reply-To: <87eebupi5k.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 19 Jul 2021 15:06:31 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:210243 Archived-At: > From: Lars Ingebrigtsen > Date: Mon, 19 Jul 2021 15:06:31 +0200 > Cc: 49632@debbugs.gnu.org, Juri Linkov > > Brian Leung writes: > > > * lisp/progmodes/gdb-mi.el (gdb): Populate gud-repeat-map. This is > > copied from the gud-gdb command. > > Instead of copying the code, perhaps it should be separated out into its > own function and then called from both places? > > But I don't quite understand why gud-repeat-map is populated in the > normal way -- i.e., in `gud-repeat-map' so that users can > redefine/override entries as usual. I admit I don't understand the rationale for the patch at all. "M-x gdb" already repeats these commands when you type just RET into the interaction buffer, so what exactly does this change do, and how can I see its effect?