bug#49687: [PATCH] Add mode-line-compact variable to Customize

bug#49687: [PATCH] Add mode-line-compact variable to Customize

[Illia Ostapyshyn]

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

This patch adds mode-line-compact to customize group mode-line so it can be
easily discovered and set through easy customization interface.


[-- Attachment #2: 0001-lisp-cus-start.el-Add-mode-line-compact-to-Customize.patch --]
[-- Type: application/octet-stream, Size: 1084 bytes --]

From 6e08cd3e533bb4fe09c91b5215aecb69e6abd971 Mon Sep 17 00:00:00 2001
From: Illia Ostapyshyn <ilya.ostapyshyn@gmail.com>
Date: Thu, 22 Jul 2021 00:30:09 +0300
Subject: [PATCH] * lisp/cus-start.el: Add mode-line-compact to Customize

---
 lisp/cus-start.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/cus-start.el b/lisp/cus-start.el
index 3c2625a8c3..4a6d58b638 100644
--- a/lisp/cus-start.el
+++ b/lisp/cus-start.el
@@ -631,6 +631,12 @@ minibuffer-prompt-properties--setter
 	     ;; The whitespace group is for whitespace.el.
 	     (show-trailing-whitespace editing-basics boolean nil
 				       :safe booleanp)
+             (mode-line-compact
+              mode-line
+              (choice (const :tag "Never (nil)" :value nil)
+                      (const :tag "Only if wider than window (long)" :value long)
+                      (const :tag "Always (t)" :value t))
+              "28.1")
 	     (scroll-step windows integer)
 	     (scroll-conservatively windows integer)
 	     (scroll-margin windows integer)
-- 
2.32.0

bug#49687: [PATCH] Add mode-line-compact variable to Customize

[Lars Ingebrigtsen]

Illia Ostapyshyn <ilya.ostapyshyn@gmail.com> writes:

> This patch adds mode-line-compact to customize group mode-line so it can be
> easily discovered and set through easy customization interface.

Thanks; applied to Emacs 28.

This change was small enough to apply without assigning copyright to the
FSF, but for future patches you want to submit, it might make sense to
get the paperwork started now, so that subsequent patches can be applied
speedily. Would you be willing to sign such paperwork?

bug#49687: [PATCH] Add mode-line-compact variable to Customize

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Date: Wed, 21 Jul 2021 23:54:07 +0200
> Cc: 49687@debbugs.gnu.org
> 
> Illia Ostapyshyn <ilya.ostapyshyn@gmail.com> writes:
> 
> > This patch adds mode-line-compact to customize group mode-line so it can be
> > easily discovered and set through easy customization interface.
> 
> Thanks; applied to Emacs 28.

IMO, showing the values in parentheses makes the description
potentially confusing.  E.g., for this description:

  "Only if wider than window (long)"

I needed to stare at it for some time before I realized that the
"(long)" part shows the underlying Lisp value.

AFAIK, we don't normally show values in parentheses like that.  Why is
it a good idea in this case (or at all)?

bug#49687: [PATCH] Add mode-line-compact variable to Customize

[Lars Ingebrigtsen]

Eli Zaretskii <eliz@gnu.org> writes:

> AFAIK, we don't normally show values in parentheses like that.  Why is
> it a good idea in this case (or at all)?

It's not -- but quite a few of the options defined in that file do this,
so it was probably just patterned on that.

I've now removed the lisp values from those strings of all the user
options defined in that form.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#49687: [PATCH] Add mode-line-compact variable to Customize

[Eli Zaretskii]

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: ilya.ostapyshyn@gmail.com,  49687@debbugs.gnu.org
> Date: Thu, 22 Jul 2021 14:15:59 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > AFAIK, we don't normally show values in parentheses like that.  Why is
> > it a good idea in this case (or at all)?
> 
> It's not -- but quite a few of the options defined in that file do this,
> so it was probably just patterned on that.
> 
> I've now removed the lisp values from those strings of all the user
> options defined in that form.

Thanks.