From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#50424: 27.2; Tab bar button mouse face not clearing entirely Date: Sun, 12 Sep 2021 19:25:14 +0300 Message-ID: <835yv5g3rp.fsf@gnu.org> References: <87eea2cebb.fsf.ref@yahoo.com> <87eea2cebb.fsf@yahoo.com> <83eea2rn8z.fsf@gnu.org> <87h7exc2dk.fsf@yahoo.com> <83lf49r4bc.fsf@gnu.org> <87czplb51o.fsf@yahoo.com> <83ilzcpt0d.fsf@gnu.org> <83mtonob41.fsf@gnu.org> <87tuiryn17.fsf@mail.linkov.net> <831r5uhpd3.fsf@gnu.org> <8735qazyjv.fsf@mail.linkov.net> <83zgsifob4.fsf@gnu.org> <87zgsii8cy.fsf@mail.linkov.net> <83k0jmfay2.fsf@gnu.org> <87lf41hlym.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19794"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 50424@debbugs.gnu.org, alan@idiocy.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 12 18:26:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mPSJ2-0004xc-8f for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 18:26:12 +0200 Original-Received: from localhost ([::1]:45024 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPSJ0-0002Bw-PT for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Sep 2021 12:26:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43630) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPSIs-00029Q-KH for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 12:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mPSIs-0005Qz-88 for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 12:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mPSIs-0007Qx-4y for bug-gnu-emacs@gnu.org; Sun, 12 Sep 2021 12:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Sep 2021 16:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50424 X-GNU-PR-Package: emacs Original-Received: via spool by 50424-submit@debbugs.gnu.org id=B50424.163146394028527 (code B ref 50424); Sun, 12 Sep 2021 16:26:02 +0000 Original-Received: (at 50424) by debbugs.gnu.org; 12 Sep 2021 16:25:40 +0000 Original-Received: from localhost ([127.0.0.1]:43494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPSIW-0007Q3-1a for submit@debbugs.gnu.org; Sun, 12 Sep 2021 12:25:40 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:54738) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mPSIN-0007PX-Ks for 50424@debbugs.gnu.org; Sun, 12 Sep 2021 12:25:38 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:34488) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mPSIH-0004yA-0z; Sun, 12 Sep 2021 12:25:25 -0400 Original-Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:3485 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mPSIG-0002qE-3c; Sun, 12 Sep 2021 12:25:24 -0400 In-Reply-To: <87lf41hlym.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 12 Sep 2021 19:06:57 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:214146 Archived-At: > From: Juri Linkov > Cc: alan@idiocy.org, luangruo@yahoo.com, 50424@debbugs.gnu.org > Date: Sun, 12 Sep 2021 19:06:57 +0300 > > > If we want the default value of tab-bar-button-margin to be a cons > > cell, let's change the default value to be a cons cell, it's not more > > complicated than setting it to a scalar, even in C. But tab-bar.el > > should use in its image specs the exact value of > > tab-bar-button-margin, it cannot decide to change it behind the back > > of the caller. > > I tried a cons cell, but it looks ugly for buttons other than the close button. > OTOH, margin 1 looks nice for all buttons: Fine by me. > diff --git a/src/dispextern.h b/src/dispextern.h > index f4c7575b35..6aefe43e19 100644 > --- a/src/dispextern.h > +++ b/src/dispextern.h > @@ -3202,7 +3202,7 @@ #define IMAGE_CACHE_BUCKETS_SIZE 1001 > > /* Default values of the above variables. */ > > -#define DEFAULT_TAB_BAR_BUTTON_MARGIN 4 > +#define DEFAULT_TAB_BAR_BUTTON_MARGIN 1 > #define DEFAULT_TAB_BAR_BUTTON_RELIEF 1 Btw, I don't see much sense in keeping the DEFAULT_TAB_BAR_BUTTON_MARGIN macro: it's used in one place only, AFAICT, so we could simply have it there literally.