From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#51473: [PATCH] Enable xwidget scrolling optimizations, and other xwidgets improvements Date: Sun, 07 Nov 2021 12:09:00 +0200 Message-ID: <835yt49t1f.fsf@gnu.org> References: <87zgqslafe.fsf.ref@yahoo.com> <87zgqslafe.fsf@yahoo.com> <875yt7plc1.fsf@gnus.org> <87mtmj9hts.fsf@yahoo.com> <87cznelojs.fsf@gnus.org> <87fssa90vv.fsf@yahoo.com> <87r1buk92k.fsf@gnus.org> <8735oa876a.fsf@yahoo.com> <87wnlmdtag.fsf@gnus.org> <87v9156dwp.fsf@yahoo.com> <83pmrdbqz2.fsf@gnu.org> <87o86xzhuw.fsf@yahoo.com> <87sfw9cha3.fsf@gnus.org> <878ry0ztjo.fsf@yahoo.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 51473@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 07 11:10:32 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjf8B-0000Ya-Sm for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 11:10:32 +0100 Original-Received: from localhost ([::1]:57452 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjf89-0000sW-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 Nov 2021 05:10:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:43962) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjf7j-0000sN-32 for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 05:10:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40254) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjf7i-0000N0-1o for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 05:10:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjf7h-00028x-T1 for bug-gnu-emacs@gnu.org; Sun, 07 Nov 2021 05:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Nov 2021 10:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51473 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51473-submit@debbugs.gnu.org id=B51473.16362797628185 (code B ref 51473); Sun, 07 Nov 2021 10:10:01 +0000 Original-Received: (at 51473) by debbugs.gnu.org; 7 Nov 2021 10:09:22 +0000 Original-Received: from localhost ([127.0.0.1]:51799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjf74-00027x-LA for submit@debbugs.gnu.org; Sun, 07 Nov 2021 05:09:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjf70-00027Y-Tv for 51473@debbugs.gnu.org; Sun, 07 Nov 2021 05:09:21 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:40728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjf6v-0008GI-Mx; Sun, 07 Nov 2021 05:09:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=GvDgzrTM+ENEeJzQxu5dI795InDOINvgabaxvQsxQrI=; b=SL8dkh0hkws1 6fhWL4RkHAfIbhCknnizOjT/ryZbN0O7Y8axPWZEHaFNgyQCapIROTXdo5b2uraS8wMsdeEi2Ayna EUtnrNklfxvX4Drq0GRon6uDfEgpyMIaxteyJ6vkcd6yojRPtWiZb1NCSGM3WMuKqdT+8jI7rqTyp eKD5A7c2pB8TMkoN5Tzd+dOtw2X7O9Dt+wUMYSZiJf2FOm45uIarxccsFXJCGI6u+CGOVDibPpWD+ VvQNMuyjLfQiR2B5gIozVFo5HvliusnoPflYxVJShytK3SlNcjAA4ojEV7oRKsLLhJkvJCrsxvfE8 pvAp5SwTG0XJcPPkpv9MVA==; Original-Received: from [87.69.77.57] (port=3603 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjf6u-0003cf-Sn; Sun, 07 Nov 2021 05:09:13 -0500 In-Reply-To: <878ry0ztjo.fsf@yahoo.com> (message from Po Lu on Sun, 07 Nov 2021 08:41:15 +0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219219 Archived-At: > From: Po Lu > Cc: Eli Zaretskii , 51473@debbugs.gnu.org > Date: Sun, 07 Nov 2021 08:41:15 +0800 > > Lars Ingebrigtsen writes: > > > I can test both, but it'd be easier to test if it was just one huge > > patch. (When applying for real, we can apply the patch series.) So can > > you post this series as one patch? > > Thanks, here you go. > --- a/src/print.c > +++ b/src/print.c > @@ -1521,8 +1521,20 @@ print_vectorlike (Lisp_Object obj, Lisp_Object printcharfun, bool escapeflag, > printchar ('>', printcharfun); > break; > > - case PVEC_XWIDGET: case PVEC_XWIDGET_VIEW: > - print_c_string ("# + case PVEC_XWIDGET: > +#ifdef HAVE_XWIDGETS > + { > + int len = sprintf (buf, "#", > + XXWIDGET (obj)->xwidget_id, > + XXWIDGET (obj)->widget_osr); > + strout (buf, len, len, printcharfun); > + break; > + } The printed representation of xwidget objects should be documented in the ELisp manual, under the "Editing Types" section. In fact, we lack a subsection there for xwidgets; it should be added. Thanks.