unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Jan Stranik <jan@stranik.org>
Cc: 53333@debbugs.gnu.org
Subject: bug#53333: Fix for crash in ebrowse
Date: Tue, 18 Jan 2022 20:09:18 +0200	[thread overview]
Message-ID: <835yqgvru9.fsf@gnu.org> (raw)
In-Reply-To: <87fspm0z47.fsf@stranik.org> (bug-gnu-emacs@gnu.org)

> Date: Mon, 17 Jan 2022 17:35:36 -0500
> From:  Jan Stranik via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> attached is a patch to ebrowse. Noticed a one-off write error in case of
> identifiers that are too long and need escaping. The patch prevents the
> write to memory outside of allocated range which on my platform caused
> segfault.

Thanks, but can you explain the need for this part:

> !           else {
> !               s++;
> !               break;
> !           }
> !       }

Why do we need to advance the pointer 's' in the 'else' clause? why
not leave it alone?

Or maybe I will understand the reason if you show some simple code
that hits this problem (which would be a good thing of its own, as
we'd then have a test to add to our test suite)?





  reply	other threads:[~2022-01-18 18:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-17 22:35 bug#53333: Fix for crash in ebrowse Jan Stranik via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-18 18:09 ` Eli Zaretskii [this message]
2022-01-19  1:32   ` Jan Stranik via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-01-20 11:45     ` Eli Zaretskii
2022-01-27 21:20       ` Jan Stranik via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yqgvru9.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=53333@debbugs.gnu.org \
    --cc=jan@stranik.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).