From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#53636: 29.0.50; face-remapping broken on master Date: Sun, 30 Jan 2022 22:25:02 +0200 Message-ID: <835yq19dk1.fsf@gnu.org> References: <87o83tib13.fsf@gnu.org> <871r0p9l4f.fsf@gnus.org> <83ee4p9izg.fsf@gnu.org> <87mtjd8485.fsf@gnus.org> <83a6fd9glm.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31951"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53636@debbugs.gnu.org, tsdh@gnu.org To: larsi@gnus.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 30 21:26:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nEGm3-0008Bb-23 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 21:26:11 +0100 Original-Received: from localhost ([::1]:51216 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nEGm1-0007yM-FU for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Jan 2022 15:26:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:49864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEGlu-0007y8-Lz for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 15:26:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44850) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nEGlu-0008Qt-AF for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 15:26:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nEGlu-0001MO-3U for bug-gnu-emacs@gnu.org; Sun, 30 Jan 2022 15:26:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jan 2022 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53636 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 53636-submit@debbugs.gnu.org id=B53636.16435743575219 (code B ref 53636); Sun, 30 Jan 2022 20:26:02 +0000 Original-Received: (at 53636) by debbugs.gnu.org; 30 Jan 2022 20:25:57 +0000 Original-Received: from localhost ([127.0.0.1]:37753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEGlp-0001M7-6v for submit@debbugs.gnu.org; Sun, 30 Jan 2022 15:25:57 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:43116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nEGll-0001Lo-Vo for 53636@debbugs.gnu.org; Sun, 30 Jan 2022 15:25:56 -0500 Original-Received: from [2001:470:142:3::e] (port=53952 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEGlg-0008K3-LY; Sun, 30 Jan 2022 15:25:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Xv5bUkHi/0mhFSfP3grx/GynkofryhQ2p19sIORiCoE=; b=q+WxuQyk+iyF WKdLblYWA7F/oTrWmnGLw9MCYYPS8JXFSMDAjVI4eJH5SzrXyv3bb7Cr5vbd5gCnmZThXoyENumIb dQJ78PuTcuXDbdSHo0cpUKV6ub4MwgsrCgf4nbuzs8uOWYPrxRw047N+lSoy7iJSej2oUXz+w3Fc0 UobzXdku22vQVXgr8C8Z8wIvBv0RCmucL7w6ct/mf1qfv//5QWigFus/LVnCVWMaHCvqhcJnRyF+T jCn7kSl54r/NAsWKjpFpvWy4KXcFufYOCVISsN36VJsUoG2WtY0AyfxbPQZNxgpbPD8zM0SimAQX4 nw/S+nZhN8ANrW5tnsYHPQ==; Original-Received: from [87.69.77.57] (port=2709 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nEGl2-0002ns-0d; Sun, 30 Jan 2022 15:25:23 -0500 In-Reply-To: <83a6fd9glm.fsf@gnu.org> (message from Eli Zaretskii on Sun, 30 Jan 2022 21:19:17 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:225629 Archived-At: > Date: Sun, 30 Jan 2022 21:19:17 +0200 > From: Eli Zaretskii > Cc: 53636@debbugs.gnu.org, tsdh@gnu.org > > > I'm not sure whether that's a bug or not? (That remapping a parent face > > has no effect.) > > But it does have effect. Try "C-x 5 b *scratch* RET" after evaluating > the first face-remap-add-relative, and you will see that it does have > effect. So it's something more subtle... > > And yes, I think the extra indirection we now have on master exposed a > problem we never saw before. Actually, I think this is a new problem on master, introduced by making the mode-line face be a parent of mode-line-active and mode-line-inactive faces. When that was done, lookup_basic_face was changed to use mode-line-active instead of mode-line, so now the mode-line face is not recomputed when face-remapping-alist is changed. Instead, we recompute mode-line-active and mode-line-inactive, but those are not in face-remapping-alist in this scenario, so they don't change on the existing frame. Do we still need the mode-line as a parent of these two faces, or can we go back to what we had before the variable-pitch mode-line changes?