From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54062: 29.0.50; [PATCH] Eshell should inform processes when a pipe is broken Date: Mon, 21 Feb 2022 20:31:15 +0200 Message-ID: <835yp8ul58.fsf@gnu.org> References: <7da3e8b2-7400-dca6-6d92-0a60e3d9c215@gmail.com> <83mtinz222.fsf@gnu.org> <83ley6y5gx.fsf@gnu.org> <83a6emxak3.fsf@gnu.org> <272c6d13-6d35-a896-1468-2c9bc3befe87@gmail.com> <83a6ekuomt.fsf@gnu.org> <87k0dof7az.fsf@gnus.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22447"; mail-complaints-to="usenet@ciao.gmane.io" Cc: jporterbugs@gmail.com, 54062@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 21 19:32:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMDU0-0005ih-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 19:32:25 +0100 Original-Received: from localhost ([::1]:54008 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMDTy-0002Ax-RJ for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 21 Feb 2022 13:32:22 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40498) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMDTh-0002AU-5S for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 13:32:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45101) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMDTd-0002I5-U8 for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 13:32:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMDTd-0002C0-Se for bug-gnu-emacs@gnu.org; Mon, 21 Feb 2022 13:32:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Feb 2022 18:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54062 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 54062-submit@debbugs.gnu.org id=B54062.16454682998398 (code B ref 54062); Mon, 21 Feb 2022 18:32:01 +0000 Original-Received: (at 54062) by debbugs.gnu.org; 21 Feb 2022 18:31:39 +0000 Original-Received: from localhost ([127.0.0.1]:38998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMDT2-0002B9-I1 for submit@debbugs.gnu.org; Mon, 21 Feb 2022 13:31:39 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMDSv-0002Ar-6h for 54062@debbugs.gnu.org; Mon, 21 Feb 2022 13:31:23 -0500 Original-Received: from [2001:470:142:3::e] (port=58602 helo=fencepost.gnu.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMDSp-0002Cd-Px; Mon, 21 Feb 2022 13:31:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=2Ty3xdpPVOSHlWiXS34o+KGu2OdBOgNjoMqltgyW7Ho=; b=gshhEoFVY3HQ qu6A2FS9ZyEQC9lLRPkuWqnK7oNs5D2jxDTy8lyv1ulC6Gqf5Nu7SuLes/7UquKEprun4pEcd9e3j 68NbtocE7wkm3u8/ce0ZqlCxBPLX4se8TX82Cd3BduOTP3ZyiQLezGTDn5W1lU5YZKnFz4/TNIzv3 9jkNF/Z5i4UGnvXRG7nVtQYS+si7sVQ7+j6uoVvZUz0AnCe5V9NujXy2OhaRTF4vckSSz3qBtAXw2 OP3wFxvQ+Gu8UxHmGFmGyONs4yGKB3Gi1eq0YG8XT8u6rpyooSgO4vVOBxDpf6zdqVDVrZXBxoXLN hGvUb+WxBQl3gHVFsq2yQQ==; Original-Received: from [87.69.77.57] (port=2566 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMDSp-0001DX-2t; Mon, 21 Feb 2022 13:31:11 -0500 In-Reply-To: <87k0dof7az.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 21 Feb 2022 18:39:16 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227379 Archived-At: > From: Lars Ingebrigtsen > Cc: Jim Porter , 54062@debbugs.gnu.org > Date: Mon, 21 Feb 2022 18:39:16 +0100 > > Eli Zaretskii writes: > > > Thanks; I have no further comments. > > So I've pushed the patch series to Emacs 29. Something's amiss here: the new test fails on MS-Windows because it signals an error inside eshell-wait-for-subprocess: Test esh-proc-test/sigpipe-exits-process backtrace: signal(eshell-pipe-broken #) eshell-output-object-to-target("killed\n" #) eshell-output-object("killed\n" nil [nil (nil . 0) (nil . 0)]) #f(compiled-function () #)() apply(#f(compiled-function () #) nil) timer-event-handler([t 25107 54636 874750 nil #f(compiled-function ( sleep-for(0.1) sit-for(0.1) (while (if all eshell-process-list (eshell-interactive-process-p)) ( (let ((start (current-time))) (while (if all eshell-process-list (es eshell-wait-for-subprocess(t) Sounds like the shell is already dead/killed when eshell-wait-for-subprocess tries to send it a string?