From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#54838: 28.1; Buffers are not updated when a directory is renamed in dired Date: Sun, 10 Apr 2022 20:38:34 +0300 Message-ID: <835yng7s9x.fsf@gnu.org> References: <87ilrh55aj.fsf@valhala.localdomain> <838rsc7tdy.fsf@gnu.org> <878rscetim.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3597"; mail-complaints-to="usenet@ciao.gmane.io" Cc: khaelin@gmail.com, 54838@debbugs.gnu.org To: Tassilo Horn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 10 19:39:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndbWr-0000m9-QA for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 19:39:13 +0200 Original-Received: from localhost ([::1]:53630 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndbWq-000081-MG for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Apr 2022 13:39:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45914) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndbWg-00007b-43 for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47456) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndbWf-0003ep-SF for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ndbWf-0001Qi-QD for bug-gnu-emacs@gnu.org; Sun, 10 Apr 2022 13:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Apr 2022 17:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54838 X-GNU-PR-Package: emacs Original-Received: via spool by 54838-submit@debbugs.gnu.org id=B54838.16496123215463 (code B ref 54838); Sun, 10 Apr 2022 17:39:01 +0000 Original-Received: (at 54838) by debbugs.gnu.org; 10 Apr 2022 17:38:41 +0000 Original-Received: from localhost ([127.0.0.1]:41353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndbWL-0001Q2-0c for submit@debbugs.gnu.org; Sun, 10 Apr 2022 13:38:41 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:52586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndbWK-0001Po-8Z for 54838@debbugs.gnu.org; Sun, 10 Apr 2022 13:38:40 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:45868) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndbWE-0003cX-Ny; Sun, 10 Apr 2022 13:38:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8XAD/Il6VA0FgYknrFvwq9AD2MszjiJYMCaihhbJApo=; b=U5D62IoLBe/E ar64DiN8W+dSr94UXqa9Sw7P25W48kW5NDZ61N0jHPweT8daUBWLjCb5nGRkfNbSufZiumv9Uf4jM JR+MuueEHvwqlDzCQ3/K/jrtJJ5ioCNgHV0kHzF0b18nIBErCIR7XXOKKVE9VU5ENAUSGigGCedBl epyYNXp6c2Q+DdPPOkyA4YYXXm02YVm80bhzRgwHf8aae13kK+b23vBdaQoeQXTStJ4oTgyqyWENf AlHLdKfCSn8LG4/X0yI0NdzPxri0UR0I1tMkrbcfCKkUIbAZFokPQ7qOxRMWT9bOv1GBTnhjr6zzs 0ZxofPodFeY047sgLSIu2w==; Original-Received: from [87.69.77.57] (port=1867 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndbWD-0002VF-N5; Sun, 10 Apr 2022 13:38:34 -0400 In-Reply-To: <878rscetim.fsf@gnu.org> (message from Tassilo Horn on Sun, 10 Apr 2022 19:19:26 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229680 Archived-At: > From: Tassilo Horn > Cc: Nicolas Martyanoff , 54838@debbugs.gnu.org > Date: Sun, 10 Apr 2022 19:19:26 +0200 > > > Tassilo, part of this bug is yet another fallout from replacing > > dired-in-this-tree-p with file-in-directory-p: the latter returns nil > > if its second arg doesn't exist, and in this scenario we are dealing > > with a directory that was already renamed to the new name. Do you > > agree with my proposed solution for that below? > > I would just revert back to using dired-in-this-tree-p and never > file-in-directory-p in those places. I've done that for many places in > 61677ac3e4685d8f81c3b90eb751d9b5e8a3732d, too, because it turned out > that the change from dired-in-this-tree-p to file-in-directory-p caused > performance problems. Thanks, will do when installing the changes.