unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>
Cc: khaelin@gmail.com, 54838@debbugs.gnu.org
Subject: bug#54838: 28.1; Buffers are not updated when a directory is renamed in dired
Date: Sun, 10 Apr 2022 20:38:34 +0300	[thread overview]
Message-ID: <835yng7s9x.fsf@gnu.org> (raw)
In-Reply-To: <878rscetim.fsf@gnu.org> (message from Tassilo Horn on Sun, 10 Apr 2022 19:19:26 +0200)

> From: Tassilo Horn <tsdh@gnu.org>
> Cc: Nicolas Martyanoff <khaelin@gmail.com>, 54838@debbugs.gnu.org
> Date: Sun, 10 Apr 2022 19:19:26 +0200
> 
> > Tassilo, part of this bug is yet another fallout from replacing
> > dired-in-this-tree-p with file-in-directory-p: the latter returns nil
> > if its second arg doesn't exist, and in this scenario we are dealing
> > with a directory that was already renamed to the new name.  Do you
> > agree with my proposed solution for that below?
> 
> I would just revert back to using dired-in-this-tree-p and never
> file-in-directory-p in those places.  I've done that for many places in
> 61677ac3e4685d8f81c3b90eb751d9b5e8a3732d, too, because it turned out
> that the change from dired-in-this-tree-p to file-in-directory-p caused
> performance problems.

Thanks, will do when installing the changes.





  reply	other threads:[~2022-04-10 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-10 15:25 bug#54838: 28.1; Buffers are not updated when a directory is renamed in dired Nicolas Martyanoff
2022-04-10 17:14 ` Eli Zaretskii
2022-04-10 17:19   ` Tassilo Horn
2022-04-10 17:38     ` Eli Zaretskii [this message]
2022-04-11  7:59   ` Nicolas Martyanoff
2022-04-11 11:33     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yng7s9x.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54838@debbugs.gnu.org \
    --cc=khaelin@gmail.com \
    --cc=tsdh@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).