unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 54964@debbugs.gnu.org, hmelman@gmail.com
Subject: bug#54964: 28.1; mistatement in NEWS about read-extended-command-predicate
Date: Sat, 16 Apr 2022 14:09:37 +0300	[thread overview]
Message-ID: <835yn91dzi.fsf@gnu.org> (raw)
In-Reply-To: <87tuate1jr.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat,  16 Apr 2022 12:59:52 +0200)

> From: Lars Ingebrigtsen <larsi@gnus.org>
> Cc: hmelman@gmail.com,  54964@debbugs.gnu.org
> Date: Sat, 16 Apr 2022 12:59:52 +0200
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > That NEWS entry describes two 'declare' forms:
> >
> >    '(declare (completion PREDICATE))'
> >    '(declare (modes MODE...))'
> >
> > Are you saying that M-S-x uses one of these two?  Then I must be
> > missing something.
> 
> Doc string:
> 
> This is like ‘execute-extended-command’, but it limits the
> completions to commands that are particularly relevant to the
> current buffer.  This includes commands that have been marked as
> being specially designed for the current major mode (and enabled
> minor modes), as well as commands bound in the active local key
> maps.

Yes, but again: how is this relevant to that particular NEWS entry?

execute-extended-command-for-buffer is covered by a separate NEWS
entry, which says:

  ** New command 'execute-extended-command-for-buffer'.
  This new command, bound to 'M-S-x', works like
  'execute-extended-command', but limits the set of commands to the
  commands that have been determined to be particularly useful with the
  current mode.

By contrast, the NEWS entry with which this bug report deals doesn't
mention execute-extended-command-for-buffer at all.  Its says this:

  ** New 'declare' forms to control completion of commands in 'M-x'.
  '(declare (completion PREDICATE))' can be used as a general predicate
  to say whether the command should be considered a completion candidate
  when completing with 'M-x TAB'.

  '(declare (modes MODE...))' can be used as a short-hand way of saying
  that the command should be considered a completion candidate when
  completing on commands from buffers in major modes derived from
  MODE..., or, if it's a minor mode, when that minor mode is enabled in
  the current buffer.

  Note that these forms will only have their effect if the
  'read-extended-command-predicate' user option is customized to call
  'command-completion-default-include-p' or a similar function.  The
  default value of 'read-extended-command-predicate' is nil, which means
  no commands that match what you have typed are excluded from being
  completion candidates.

Is something wrong/inaccurate with the text of the above NEWS entry?
An honest question, because I really don't see anything wrong here.





  reply	other threads:[~2022-04-16 11:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-15 20:16 bug#54964: 28.1; mistatement in NEWS about read-extended-command-predicate Howard Melman
2022-04-16  6:35 ` Eli Zaretskii
2022-04-16  9:27   ` Lars Ingebrigtsen
2022-04-16 10:52     ` Eli Zaretskii
2022-04-16 10:59       ` Lars Ingebrigtsen
2022-04-16 11:09         ` Eli Zaretskii [this message]
2022-04-16 13:30           ` Howard Melman
2022-04-16 13:55             ` Eli Zaretskii
2022-04-16 14:20               ` Howard Melman
2022-04-16 14:25                 ` Lars Ingebrigtsen
2022-04-16 16:23                   ` Eli Zaretskii
2022-04-16 16:27                     ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835yn91dzi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=54964@debbugs.gnu.org \
    --cc=hmelman@gmail.com \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).