From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58042: 29.0.50; ASAN use-after-free in re_match_2_internal Date: Sat, 24 Sep 2022 17:56:55 +0300 Message-ID: <835yhcom6g.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17805"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58042@debbugs.gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 24 17:01:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc6ed-0004UN-To for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Sep 2022 17:01:20 +0200 Original-Received: from localhost ([::1]:37666 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oc6eb-00032c-HA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Sep 2022 11:01:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44112) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc6bS-0008Og-9d for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 10:58:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oc6bR-0006NP-W6 for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 10:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oc6bR-0002tt-IC for bug-gnu-emacs@gnu.org; Sat, 24 Sep 2022 10:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2022 14:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58042 X-GNU-PR-Package: emacs Original-Received: via spool by 58042-submit@debbugs.gnu.org id=B58042.166403143711078 (code B ref 58042); Sat, 24 Sep 2022 14:58:01 +0000 Original-Received: (at 58042) by debbugs.gnu.org; 24 Sep 2022 14:57:17 +0000 Original-Received: from localhost ([127.0.0.1]:44909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc6aj-0002sc-Dm for submit@debbugs.gnu.org; Sat, 24 Sep 2022 10:57:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:35102) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc6ah-0002sO-EV for 58042@debbugs.gnu.org; Sat, 24 Sep 2022 10:57:15 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:35404) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc6ac-000650-4b; Sat, 24 Sep 2022 10:57:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=lNKN33By/qXYSFpNdQZSnnmTgnGN9sq3bPaJ+8MXY7I=; b=Dj3Ba9i8kSp8D01MXJ48 P6lZMIsGsDl1a6ByyQo7pwA7zgQzR2sFsOTwWiT99nkmKPe3VLtop5X7zAPeYTBA1ldc6+2zX4OxB ppM/3rellryEKJ3sdYqRk7hhxdxTfq7FxMfdDFfSN/ZIdC4zsjlx0DAdl78mvEjmCxGQh9Pl4iJS5 geNgcAPYRBYTgOR4oqJXDfYvLHh3UCX116Su8wIJZF2SNIChy2utEWEm/gMuvM2/TSVBskUscJ/d8 x3dYlgv1gKzmDA5cPXSfALanIOEd5YxIwEAvrUav/cqFLAafG9lG7MdrxYVtCGegTMz+vPBXoOb0O B/1SNhZZOHJvmQ==; Original-Received: from [87.69.77.57] (port=3166 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc6ab-000651-KS; Sat, 24 Sep 2022 10:57:09 -0400 In-Reply-To: (message from Gerd =?UTF-8?Q?M=C3=B6llmann?= on Sat, 24 Sep 2022 16:17:20 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243541 Archived-At: > From: Gerd Möllmann > Date: Sat, 24 Sep 2022 16:17:20 +0200 > > Gerd Möllmann writes: > > > ==79227==ERROR: AddressSanitizer: heap-use-after-free on address 0x00011f81e7d1 at pc 0x0001005825c4 bp 0x00016fdcf370 sp 0x00016fdcf368 > > READ of size 1 at 0x00011f81e7d1 thread T0 > > #0 0x1005825c0 in re_match_2_internal regex-emacs.c:4352 > > #1 0x10057e5cc in rpl_re_search_2 regex-emacs.c:3383 > > #2 0x10057d1c4 in rpl_re_search regex-emacs.c:3177 > > #3 0x10056115c in fast_string_match_internal search.c:492 > > #4 0x1005045c0 in fast_string_match lisp.h:4818 > > #5 0x100504018 in Ffind_file_name_handler fileio.c:324 > > #6 0x1006dbe5c in openp lread.c:1911 > > #7 0x1006d8844 in Fload lread.c:1302 > > #8 0x1006e1af0 in save_match_data_load lread.c:1630 > > #9 0x10064f8cc in load_with_autoload_queue eval.c:2269 > > #10 0x10067d2f8 in Frequire fns.c:3274 > > Forget to copy the part where it is freed: > > freed by thread T0 here: > #0 0x103332de4 in wrap_free+0x98 (libclang_rt.asan_osx_dynamic.dylib:arm64e+0x3ede4) > #1 0x100985e38 in rpl_free free.c:48 > #2 0x1005b71a4 in lisp_free alloc.c:1038 > #3 0x1005cbda4 in compact_small_strings alloc.c:2191 > #4 0x1005c9f24 in sweep_strings alloc.c:2072 > #5 0x1005bd028 in gc_sweep alloc.c:7397 > #6 0x1005bb178 in garbage_collect alloc.c:6245 > #7 0x1005ba694 in maybe_garbage_collect alloc.c:6090 > #8 0x1006505ac in maybe_gc lisp.h:5624 > #9 0x100648ffc in Ffuncall eval.c:2972 > #10 0x10064bcd0 in internal_condition_case_n eval.c:1555 > #11 0x1000cdc8c in safe__call xdisp.c:3026 > #12 0x1000cdfc4 in safe__call1 xdisp.c:3062 > #13 0x1001d6404 in prepare_menu_bars xdisp.c:13572 > #14 0x1000f2340 in redisplay_internal xdisp.c:16523 > #15 0x100108f34 in redisplay xdisp.c:16105 > #16 0x10088fa84 in -[EmacsView layoutSublayersOfLayer:] nsterm.m:8662 > #17 0x1900a9624 in CA::Layer::layout_if_needed(CA::Transaction*)+0x224 (QuartzCore:arm64e+0x20624) > #18 0x1901f661c in CA::Context::commit_transaction(CA::Transaction*, double, double*)+0x1c0 (QuartzCore:arm64e+0x16d61c) > #19 0x19008b4c8 in CA::Transaction::commit()+0x2bc (QuartzCore:arm64e+0x24c8) > #20 0x18bee1698 in __62+[CATransaction(NSCATransaction) NS_setFlushesWithDisplayLink]_block_invoke+0x12c (AppKit:arm64e+0x1ac698) > #21 0x18c646754 in ___NSRunLoopObserverCreateWithHandler_block_invoke+0x3c (AppKit:arm64e+0x911754) > #22 0x1892101a0 in __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__+0x20 (CoreFoundation:arm64e+0x841a0) > #23 0x18920fff0 in __CFRunLoopDoObservers+0x24c (CoreFoundation:arm64e+0x83ff0) > #24 0x18920f524 in __CFRunLoopRun+0x300 (CoreFoundation:arm64e+0x83524) > #25 0x18920ea80 in CFRunLoopRunSpecific+0x254 (CoreFoundation:arm64e+0x82a80) > #26 0x191e4e334 in RunCurrentEventLoopInMode+0x120 (HIToolbox:arm64e+0x32334) > #27 0x191e4dfc0 in ReceiveNextEventCommon+0x140 (HIToolbox:arm64e+0x31fc0) > #28 0x191e4de64 in _BlockUntilNextEventMatchingListInModeWithFilter+0x44 (HIToolbox:arm64e+0x31e64) > #29 0x18bd76518 in _DPSNextEvent+0x358 (AppKit:arm64e+0x41518) So it was freed by GC, which probably relocated string data or something. But I don't understand the relation between these two backtraces: was the one that accessed a freed string called by the one which triggered GC? IOW, what is the relation between the call to 'require', which ended up calling re_match_2_internal, and the call to prepare_menu_bars, which triggered GC? re_search gets Lisp strings as its arguments, so unless GC was called while the regexp search was in progress, I cannot understand how this could happen. Is there any way to know which argument of re_match_2_internal was used to access the free'd heap?