From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58721: 28.2; dired with delete-by-moving-to-trash can't trash directory twice Date: Sun, 30 Oct 2022 21:51:18 +0200 Message-ID: <835yg1f5u1.fsf@gnu.org> References: <21142.1667153909@alto> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com To: Mike Kupfer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 30 20:52:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opEM1-0007iD-Jb for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 30 Oct 2022 20:52:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opELk-0007Pz-Q2; Sun, 30 Oct 2022 15:52:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opELj-0007P1-1i for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:52:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1opELi-0005cY-Ch for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1opELh-0006LB-S8 for bug-gnu-emacs@gnu.org; Sun, 30 Oct 2022 15:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Oct 2022 19:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58721 X-GNU-PR-Package: emacs Original-Received: via spool by 58721-submit@debbugs.gnu.org id=B58721.166715950324344 (code B ref 58721); Sun, 30 Oct 2022 19:52:01 +0000 Original-Received: (at 58721) by debbugs.gnu.org; 30 Oct 2022 19:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:39050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opELO-0006Ka-Lw for submit@debbugs.gnu.org; Sun, 30 Oct 2022 15:51:42 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:53010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opELN-0006KO-0q for 58721@debbugs.gnu.org; Sun, 30 Oct 2022 15:51:41 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opELH-0005YP-HN; Sun, 30 Oct 2022 15:51:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+3CXURpunwrZILk+xUykqFWRTk/evCjS4lhAYZpyOPM=; b=a6liTHbfJ+jF 3NMRmim0rwa2nfVooHlsS/mJtFA4oZWm9ItUCZd6d15w+uPAVbP/j5H5tWw6J0EjVZ3d01oNMCbYm WXIQBGwjrhDsmxJy1YlGCA3dIbq0u+MPZAccgXM9FZx2CqDWoKTkGT0PooBdF2+Rz/Kqsu7fs22B5 zdIyDeaLXy7pleA81JulVdEvWj4EhLoMnFjqfweB5zP/5GsYhmIO4u9frJ5JCvVm75lqX8Wbyc1iW XiehZmOrIoCeu9Np2bMrdFWtrSTHRBRAUfSK7CPLq3yYBYaR6Jp7jH81jdX+7mDippZQxnQdEZmRZ gvBlobUVwVq0qYQRyNqMvg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opELH-0005zm-0X; Sun, 30 Oct 2022 15:51:35 -0400 In-Reply-To: <21142.1667153909@alto> (message from Mike Kupfer on Sun, 30 Oct 2022 11:18:29 -0700) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "bug-gnu-emacs" Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:246647 Archived-At: > From: Mike Kupfer > cc: 58721@debbugs.gnu.org, gusbrs.2016@gmail.com > Date: Sun, 30 Oct 2022 11:18:29 -0700 > > Eli Zaretskii wrote: > > > Looks good, but maybe add to the comment the reason _why_ we don't use > > rename-file for directories. You explained _what_ we do, but not > > _why_. > > Do you mean something like > > -----8<-----8<----- > Fix cross-filesystem directory trashing (Bug#58721) > > * lisp/files.el (move-file-to-trash): When trashing a directory, > copy it into the trash folder and then delete it, rather than > using rename-file. rename-file can only be used when the > to-be-trashed directory and the trashcan live in the same filesystem; > this approach handles both that case and the different-filesystem case. > ----->8----->8----- I meant in the code, not the log message, and I meant to tell more detail. But never mind, I can always add it later myself.