From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 58909@debbugs.gnu.org
Subject: bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save
Date: Wed, 02 Nov 2022 20:42:20 +0200 [thread overview]
Message-ID: <835yfx9p0z.fsf@gnu.org> (raw)
In-Reply-To: <39e03350-2783-fa90-5d66-26e47abe100d@gmail.com> (message from Jim Porter on Wed, 2 Nov 2022 11:17:00 -0700)
> Date: Wed, 2 Nov 2022 11:17:00 -0700
> Cc: 58909@debbugs.gnu.org
> From: Jim Porter <jporterbugs@gmail.com>
>
> > If that's because you want to support the C-g case, then don't: that
> > is a separate problem.
>
> Yeah, this subthread about 'delete-frame' was just to support the C-g
> case. Aside from that, I think doing this inside 'server-delete-client'
> would be fine. However, at least for this bug, adding a hook that runs
> in 'server-delete-client' doesn't add anything that
> 'delete-frame-functions' doesn't already allow. ('server-delete-client'
> is called from a hook in 'delete-frame-functions' in this case anyway.)
We cannot have behavior specific to server.el coded outside of
server.el. So I don't think I understand what you are saying here.
My suggestion is not to add a hook, it is to add a prompt for the user
when the last client frame is deleted, and do it optionally.
> > Waaaay too complicated for such a simple problem. Please, let's just
> > prompt the user from server-delete-client (and do that under some
> > opt-in option), and be done with that.
>
> If you mean adding a defcustom, I thought we'd agreed not to do that
> (see the beginning of your message here[1]).
Yes, but you keep pushing...
> Would it make sense (possibly in a separate bug) to at least make sure
> that the 'server-mode' minor mode is always active when the server is
> running? The server.el code sometimes uses 'server-mode' and sometimes
> uses 'server-start', with the end result being that the minor mode may
> or may not be active depending on the way the server was started. That
> seems like a bug all on its own.
Maybe it's a bug, but then it's really old.
I'm not sure I understand the purpose of this minor mode, and we
ourselves start the server in the daemon mode by a direct call to
server-start. Also, server-start is a command, and many users (myself
included) invoke it interactively.
Why is it important to have the mode turned on? What can a mode do
that we cannot do without a mode?
next prev parent reply other threads:[~2022-11-02 18:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-30 22:29 bug#58909: 29.0.50; [WIP PATCH] Deleting the last frame of an emacsclient doesn't ask to save Jim Porter
2022-10-31 12:44 ` Eli Zaretskii
2022-10-31 17:36 ` Jim Porter
2022-10-31 18:25 ` Eli Zaretskii
2022-10-31 19:38 ` Jim Porter
2022-10-31 19:52 ` Eli Zaretskii
2022-10-31 20:28 ` Jim Porter
2022-11-01 6:17 ` Eli Zaretskii
2022-10-31 19:28 ` Jim Porter
2022-10-31 19:43 ` Eli Zaretskii
2022-10-31 20:01 ` Jim Porter
2022-10-31 20:21 ` Eli Zaretskii
2022-10-31 21:06 ` Jim Porter
2022-11-01 6:39 ` Eli Zaretskii
2022-11-01 16:11 ` Jim Porter
2022-11-01 22:39 ` Jim Porter
2022-11-02 12:16 ` Eli Zaretskii
2022-11-02 16:36 ` Jim Porter
2022-11-02 17:11 ` Eli Zaretskii
2022-11-02 18:17 ` Jim Porter
2022-11-02 18:42 ` Eli Zaretskii [this message]
2022-11-02 19:16 ` Jim Porter
2022-11-02 19:23 ` Eli Zaretskii
2022-11-02 19:57 ` Jim Porter
2022-11-02 20:09 ` Eli Zaretskii
2022-11-02 22:09 ` bug#58909: 29.0.50; [PATCH] " Jim Porter
2022-11-03 6:25 ` Eli Zaretskii
2022-11-06 20:23 ` Jim Porter
2022-11-08 14:47 ` Eli Zaretskii
2022-11-08 15:08 ` Robert Pluim
2022-11-08 15:13 ` Eli Zaretskii
2022-11-08 15:29 ` Robert Pluim
2022-11-08 16:52 ` Jim Porter
2022-11-09 10:06 ` Robert Pluim
2022-11-17 5:17 ` Jim Porter
2023-09-07 21:03 ` bug#58909: 29.0.50; [WIP PATCH] " Stefan Kangas
2023-09-08 1:21 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835yfx9p0z.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=58909@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).