From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60311: json-available-p: make dynamically correct for Windows Date: Mon, 26 Dec 2022 15:29:58 +0200 Message-ID: <835ydy2syx.fsf@gnu.org> References: <83wn6f330g.fsf@gnu.org> <87FCD796-629F-44AE-B539-2DDAE6C148F2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33311"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60311-done@debbugs.gnu.org To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 26 14:31:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p9nZg-0008W9-Qk for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Dec 2022 14:31:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p9nZO-0000ES-Uy; Mon, 26 Dec 2022 08:31:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9nZG-0000Dp-Hy for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 08:31:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p9nZG-0005Si-3r for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 08:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p9nZF-0002HY-Vs for bug-gnu-emacs@gnu.org; Mon, 26 Dec 2022 08:31:01 -0500 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Dec 2022 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60311 X-GNU-PR-Package: emacs Mail-Followup-To: 60311@debbugs.gnu.org, eliz@gnu.org, mattias.engdegard@gmail.com Original-Received: via spool by 60311-done@debbugs.gnu.org id=D60311.16720614038621 (code D ref 60311); Mon, 26 Dec 2022 13:31:01 +0000 Original-Received: (at 60311-done) by debbugs.gnu.org; 26 Dec 2022 13:30:03 +0000 Original-Received: from localhost ([127.0.0.1]:50950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9nYI-0002Ev-Oi for submit@debbugs.gnu.org; Mon, 26 Dec 2022 08:30:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:60184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p9nYH-0002E2-Bm for 60311-done@debbugs.gnu.org; Mon, 26 Dec 2022 08:30:01 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9nYC-0004Ul-1I; Mon, 26 Dec 2022 08:29:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=CMFVwby6/Fz2+O3DJo8HhbLx67yyYDZxAt1NUZIabz0=; b=SKH4Gq/Pip41v2r5Jj/R FilmiNSw/aYTqCPRTgknmW7KKPM4UFHdheijOBGamwXxRTph9rQS+A0LwZ9sxDQ4l5FkBHCdO0fQ/ 7HcVvugYaj2+BWHWw1NRoK79itt4I4Lo+S62kQozhv3KK/GtiOBqEKFHM7rXytjV1sbn1I8KEKp9c P84KcLn9rLE+nX6+alSrxiGAjUQzBl7pPN+Ff0+VS51G6+AHtXhXMEw50xCgPpVtThYp5wZkhLppu vKV2v+xcbYbH/j5hv7EheqebJ1HkPhtxd8MEsgj4jDJVd6Hn4XL8YhVarlVCFJkg7/6wLFEm55TgG CLqajtkWFa5JTw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p9nYB-0004di-Dg; Mon, 26 Dec 2022 08:29:55 -0500 In-Reply-To: <87FCD796-629F-44AE-B539-2DDAE6C148F2@gmail.com> (message from Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= on Mon, 26 Dec 2022 13:11:21 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251902 Archived-At: > From: Mattias Engdegård > Date: Mon, 26 Dec 2022 13:11:21 +0100 > Cc: 60311@debbugs.gnu.org > > 25 dec. 2022 kl. 16.40 skrev Eli Zaretskii : > > > Yes, you are right. But please come up with a smaller changeset which > > only changes what strictly needs to be changed. Or if you want, I can > > do this myself. > > Since you have very specific ideas about how to go about it it's better that you make the change yourself. Done. > > why not just > > > > (and (fboundp 'json--available-p) > > (json--available-p)) > > Calling `fboundp` at run time is wasteful, and that patch used the presence of json--available-p to indicate whether it needs to be called at run time (on Windows only, but it's good to keep that platform-dependency in one place). Yes, but using eval-when-compile precludes defining json--available-p at run time, something that I don't like doing in Emacs, since it's IMO against the Emacs's spirit of being interpreter based. So I went with the simpler definition that doesn't assume functions are only defined at byte-compile time. Thanks, I'm now closing the bug.