From: Eli Zaretskii <eliz@gnu.org>
To: Protesilaos Stavrou <info@protesilaos.com>
Cc: yandros@gmail.com, 60580@debbugs.gnu.org
Subject: bug#60580: 29.0.60; crash in xdisp.c with modus theme and display-fill-column-indicator
Date: Fri, 06 Jan 2023 09:12:17 +0200 [thread overview]
Message-ID: <835ydkw2zy.fsf@gnu.org> (raw)
In-Reply-To: <87wn60pb0e.fsf@protesilaos.com> (message from Protesilaos Stavrou on Fri, 06 Jan 2023 06:01:05 +0200)
> From: Protesilaos Stavrou <info@protesilaos.com>
> Cc: 60580@debbugs.gnu.org
> Date: Fri, 06 Jan 2023 06:01:05 +0200
>
> > ;;;;; display-fill-column-indicator-mode
> > `(fill-column-indicator ((,class :height 1 :background ,bg-region :foreground ,bg-region)))
> >
> > I have no idea what is ":height 1" about, but I think it's wrong and
> > should be replaced with some reasonable value.
>
> The ":height 1" has been there for many versions and never caused a
> problem of this sort.
I'm guessing that this is because almost no one builds Emacs with the
assertions enabled (--enable-testing=yes at configure time). I do,
but the problem doesn't happen on my system, so I haven't seen it,
either.
> The reason it is like this is to make the indicator a contiguous
> line that is not affected by variations in font heights and/or a high
> 'line-spacing' value. Otherwise the indicator can appear as a dashed
> line.
Why do you assume that ":height 1" will avoid this problem? I think
you are just using some undocumented side effect of the
implementation, as there's no reason to believe using such small
height of the face can solve the problem with occasional 1-pixel gaps
in the fill-column indicator.
But let's first see if my latest changes prevent the assertion
violations even without changing the themed faces.
next prev parent reply other threads:[~2023-01-06 7:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-05 19:19 bug#60580: 29.0.60; crash in xdisp.c with modus theme and display-fill-column-indicator chad
2023-01-05 19:57 ` Eli Zaretskii
2023-01-05 20:03 ` Eli Zaretskii
2023-01-05 20:35 ` Eli Zaretskii
2023-01-06 4:01 ` Protesilaos Stavrou
2023-01-06 7:12 ` Eli Zaretskii [this message]
2023-01-09 21:41 ` chad
2023-01-10 3:27 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835ydkw2zy.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=60580@debbugs.gnu.org \
--cc=info@protesilaos.com \
--cc=yandros@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).