From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#62450: 29.0.60; Skip failing tests on Cygwin with native compilation Date: Sun, 26 Mar 2023 07:44:52 +0300 Message-ID: <835yaoazp7.fsf@gnu.org> References: <519b122a-a46c-0abd-6bc8-a4dc64f869ac@cornell.edu> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35688"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62450@debbugs.gnu.org To: Ken Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 26 06:46:44 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgIHC-0008vS-2F for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 Mar 2023 06:46:42 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgIH4-0007pk-HS; Sun, 26 Mar 2023 00:46:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIGY-0007ek-AR for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:46:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgIGY-00040P-1m for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:46:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgIGX-0008VG-NY for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 00:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 04:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62450 X-GNU-PR-Package: emacs Original-Received: via spool by 62450-submit@debbugs.gnu.org id=B62450.167980590232594 (code B ref 62450); Sun, 26 Mar 2023 04:46:01 +0000 Original-Received: (at 62450) by debbugs.gnu.org; 26 Mar 2023 04:45:02 +0000 Original-Received: from localhost ([127.0.0.1]:43809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgIFZ-0008TN-Ri for submit@debbugs.gnu.org; Sun, 26 Mar 2023 00:45:02 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:37186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgIFY-0008TA-Ay for 62450@debbugs.gnu.org; Sun, 26 Mar 2023 00:45:01 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIFS-0003Dg-EG; Sun, 26 Mar 2023 00:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=k69e6w5GIE7dLKNc2OostacRL2tOxxUzE/GJl9UxMxM=; b=RJnh8+MrAcH5 4KV9XzHSmns6KFwShiiNt9xpuFIT52mqrCjybQzi7rnaPoAZrgxE+Gs/kEQlwG71MEge4nbR4967i HcTicXKxVROpsxiR13iiIFafa3sL7nBkSKa1b2ReAM7QLPVu1mYDSXvd4G821MgHLhYFJ8yqqdUgP l/lKxv+sq0T+wf5n4kn34lRzZ1eyz9bkg+wUJ3SHBO4TC1fspxfpn0N5AFPo8lAh6dBwf9V/lktE1 1VCb+z4E/eQHLooPE8sP+yPwQxOhYY2fm62CD+/pex5aTUlfNpiT/3YuTTQMCz2gQYlliLNYsLl3b gNh8NfWCBJV01ybr6Mul/A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIFQ-0002SE-BT; Sun, 26 Mar 2023 00:44:53 -0400 In-Reply-To: <519b122a-a46c-0abd-6bc8-a4dc64f869ac@cornell.edu> (message from Ken Brown on Sat, 25 Mar 2023 16:55:49 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258649 Archived-At: > Date: Sat, 25 Mar 2023 16:55:49 -0400 > From: Ken Brown > > When 'make check' is run on Cygwin and Emacs has been built with native > compilation, all the tests in comp-tests.el and benchmark-tests.el fail > with fork errors, for the reasons explained in etc/PROBLEMS. I don't > see an easy way to fix this by rebasing, as is done elsewhere in the > code, and I don't think it's worth investing any effort into this just > for the sake of making some tests pass. I propose that we just skip > these tests. > > Patch attached (with a placeholder for the bug number). OK for emacs-29? OK, but please add in both places comments explaining the reason, and in particular include there a pointer to etc/PROBLEMS. (I do wonder whether this is a good idea in the long run. Native compilation is here to stay, so avoiding its testing for Cygwin might not be the best solution. The PROBLEMS entry seems to imply that relatively simple measures, which the test suite could take, could avoid the fork failures, so my recommendation would be to try to find a better fix in the future, albeit not in Emacs 29.)