From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#63469: 29.0.90; project.el doesn't add menu-bar entries Date: Fri, 19 May 2023 21:28:28 +0300 Message-ID: <835y8otbub.fsf@gnu.org> References: <834jod1lvc.fsf@gnu.org> <83o7mkz2ap.fsf@gnu.org> <83sfbvxkj3.fsf@gnu.org> <3d97111e-794d-eeef-73b0-ee3f6f5f15d5@gutov.dev> <83jzx6w2bg.fsf@gnu.org> <6a3eed52-3248-74f9-bcaf-bf12660ae0ed@gutov.dev> <83h6savsz4.fsf@gnu.org> <83mt21vfgl.fsf@gnu.org> <86mt211vk3.fsf@mail.linkov.net> <0ce4532f-03aa-6afe-bd8f-8ef1df6615de@gutov.dev> <86ilco7qbs.fsf@mail.linkov.net> <83r0rctxbc.fsf@gnu.org> <867ct4b4ds.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14944"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 63469@debbugs.gnu.org, sbaugh@janestreet.com To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 19 20:29:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q04r2-0003e6-Ls for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 May 2023 20:29:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q04ql-0007z4-0F; Fri, 19 May 2023 14:29:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q04qd-0007yo-3V for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:29:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q04qc-0003kp-RY for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q04qc-0000GY-GN for bug-gnu-emacs@gnu.org; Fri, 19 May 2023 14:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 18:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63469 X-GNU-PR-Package: emacs Original-Received: via spool by 63469-submit@debbugs.gnu.org id=B63469.1684520900971 (code B ref 63469); Fri, 19 May 2023 18:29:02 +0000 Original-Received: (at 63469) by debbugs.gnu.org; 19 May 2023 18:28:20 +0000 Original-Received: from localhost ([127.0.0.1]:57394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04pw-0000Fb-5k for submit@debbugs.gnu.org; Fri, 19 May 2023 14:28:20 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:48956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04pv-0000FP-1y for 63469@debbugs.gnu.org; Fri, 19 May 2023 14:28:19 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q04po-0003fq-PI; Fri, 19 May 2023 14:28:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=u3fV4qwMKA6F9eFKttvfjw3+/N4tFwMvFUwZVonD/o0=; b=a24PSvj18cFz UXIih1q8sKJJr16d0OUpNbp4FTch83dM56uWZKAvBtXJ5GgGTk9VyhbUI/mIjyKaUy//Bx4BNDDe/ Dc2mGw0N+YSKJ5SHdhbGd4K7Azrbw+NJ/relNqweHE/6W5zgzi1vfG4C/BXgKJVnGJQ0EsaZGlpbt SeZ9PKfzt258ao0enkj/TG1IbVe2nAFmQyyCUwxT1Nhnc0LAHoTtZRFxwkocZZuYQ1vrjExw+ZYm2 xXTrTRJRYywMakSnHfkMM79u07REFOQZTOBJGL2Rwz9R8M3regMfAuKs2zf/IQBg3Qjny4NI1XmXp yhxRpdUpWoRFkikqi99+qQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q04po-0003Na-8Y; Fri, 19 May 2023 14:28:12 -0400 In-Reply-To: <867ct4b4ds.fsf@mail.linkov.net> (message from Juri Linkov on Fri, 19 May 2023 20:46:55 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262023 Archived-At: > From: Juri Linkov > Cc: dmitry@gutov.dev, sbaugh@janestreet.com, 63469@debbugs.gnu.org > Date: Fri, 19 May 2023 20:46:55 +0300 > > >> +(define-minor-mode project-mode > >> + "Toggle display of project menu in the project-aware buffers." > >> + :lighter " Pro" > >> + :keymap (define-keymap "" project-mode-menu)) > > > > If this mode is only for showing the menu, then at least the mode's > > name should reflect that. > > It can be used for anything. For example, to display the project name > on the mode-line. (Then better to cache the project name in a new > buffer-local variable.) I don't see anything but the menu in the patch you suggested. I understand that in principle we could do many things there, but if you are proposing a real patch, not just an initial idea, please show all of the code you want to include in this mode.