From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64075: 28.2; ispell broken on uncolored terminals Date: Thu, 15 Jun 2023 08:36:28 +0300 Message-ID: <835y7puw0z.fsf@gnu.org> References: <42ff58c7e8e4095a1f34@heytings.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22077"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64075@debbugs.gnu.org, gregory@heytings.org To: Al Petrofsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jun 15 07:37:28 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q9ffj-0005Zr-Qj for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 15 Jun 2023 07:37:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q9ffV-0002lZ-70; Thu, 15 Jun 2023 01:37:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9ffL-0002kT-S5 for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 01:37:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q9ffK-0000e6-KZ for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 01:37:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q9ffK-0006GQ-Fi for bug-gnu-emacs@gnu.org; Thu, 15 Jun 2023 01:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Jun 2023 05:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64075 X-GNU-PR-Package: emacs Original-Received: via spool by 64075-submit@debbugs.gnu.org id=B64075.168680737724024 (code B ref 64075); Thu, 15 Jun 2023 05:37:02 +0000 Original-Received: (at 64075) by debbugs.gnu.org; 15 Jun 2023 05:36:17 +0000 Original-Received: from localhost ([127.0.0.1]:45957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9fea-0006FQ-NW for submit@debbugs.gnu.org; Thu, 15 Jun 2023 01:36:17 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:40966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q9feX-0006FB-UC for 64075@debbugs.gnu.org; Thu, 15 Jun 2023 01:36:14 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9feR-0000YJ-Ux; Thu, 15 Jun 2023 01:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=pCST+SNUYoMiTeK3t6g5ZT6xEcZGTRV6emQa2zVzyQU=; b=YfE1bSRYeelf UOtS2xfdocxopGDGNixM3t6mEKpgy4ZdBQNIcBh0eFNkkxClBka7RpXT87W/epciFgutJq6eMJorO LNKtY7gFmCEEdArq8ZyTrJNzgxbCP/stvCPsTo0J5QIDKn7ZkU2sopUzE+itnWQOKrKIdUPepRQa+ bNdol4W/4d43+wlouSZGxymPNWg+xOtV2yNx9LWaBcUFwIeHQ6XO1PYsUExv4nr/SjpDTbbYpbCFD 2XqTK5Jw8JTCZ8D/TK1wJNhiszST2m/HP6xBe1s/xKPuxVh7W1ZtbPpi5hnF/rKSDqTV2qymlU0Sb jAA8298uyDNCnSjYm7fFMw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q9feQ-0003IO-UG; Thu, 15 Jun 2023 01:36:07 -0400 In-Reply-To: (message from Al Petrofsky on Wed, 14 Jun 2023 19:48:37 -0400) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263394 Archived-At: > Cc: 64075@debbugs.gnu.org > From: Al Petrofsky > Date: Wed, 14 Jun 2023 19:48:37 -0400 > > Still, this anachronistic kludge should really be nuked entirely. Why? And what's "anachronistic" about that code? > Even with the current fix, it fails to use ispell-highlight-face, > instead always using inverse-video. Why is that a problem? This function exists so that even the dumbest terminals could be used for spell-checking with reasonable convenience. > By "nuked entirely" I mean: > (1) delete ispell-highlight-spelling-error > (2) delete ispell-highlight-spelling-error-generic > (3) rename ispell-highlight-spelling-error-overlay > to ispell-highlight-spelling-error Sorry, not going to happen. You are suggesting to delete a useful capability for no good reason, just because you happen to think it's "anachronistic". Unlike what you seem to think, display-color-p is not "a 20th-century kludge from before face support for ttys was added in emacs-21 in 2001". Quite to the contrary, display-color-p was introduced with Emacs 21, to replace references to window-system (which _was_ "the 20-century kludge" for requesting faces) in a way that would support text-mode terminals. Now, I'm okay will adding more tests to display-color-p, for monochrome terminals that can support other face attributes which will make the misspelled word stand out, but then the ispell-highlight-face should probably be modified accordingly, keeping in mind that (a) the user could customize the 'isearch' and/or 'highlight' faces from which it inherits, and (b) face customization is global, not specific to frame, let alone Emacs command, and users rarely customize faces in complex ways that can account for frame capabilities. And in any case, we should keep that code for terminals which can only support inverse video. There's no reason to delete it, none whatsoever.