From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64298: 29.0.92; Fixes for several todo-mode bugs Date: Mon, 26 Jun 2023 14:48:43 +0300 Message-ID: <835y7axx44.fsf@gnu.org> References: <87leg6v9yg.fsf@gmx.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3460"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64298@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jun 26 13:49:34 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qDkir-0000XT-Rt for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 26 Jun 2023 13:49:33 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qDkib-0001HS-HX; Mon, 26 Jun 2023 07:49:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDkiN-0001EP-9m for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 07:49:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qDkiM-0001DL-Lf for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 07:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qDkiL-0002zl-TC for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2023 07:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Jun 2023 11:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64298 X-GNU-PR-Package: emacs Original-Received: via spool by 64298-submit@debbugs.gnu.org id=B64298.168778011111453 (code B ref 64298); Mon, 26 Jun 2023 11:49:01 +0000 Original-Received: (at 64298) by debbugs.gnu.org; 26 Jun 2023 11:48:31 +0000 Original-Received: from localhost ([127.0.0.1]:44686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDkhr-0002ye-7T for submit@debbugs.gnu.org; Mon, 26 Jun 2023 07:48:31 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:56142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDkhp-0002xs-4Y for 64298@debbugs.gnu.org; Mon, 26 Jun 2023 07:48:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDkhj-00011d-HD; Mon, 26 Jun 2023 07:48:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=oneMYFwhDSuCqz9ntFHvdjimJgNM5FOQxD5hHwBgMic=; b=D3YziX3X/NaP aoogiUFQ6zimiDgMkdr6BwTOXBclPfwB2HRQn/Vvd5ic/6oU3O84HviPanR0IU13JTEuSGBRlBFAT CJaG9WOzYg+M9Nf5vRcJFzfCHwjh/sKDzqULEFQJT6c4PRg5YTUapQr+Oqf5X0W4dBfoiq2JDK5wF 4yKtu4QcpgPtu6bK8P40nCensUXM+NAW6NOnZQwG18LngaUEe4jO639m3fpjf+4oPDLQrk3GDzpw5 XnwfLf9Zdw3+3s12wWUKW1uQeKmGTqWHOVQuIuA3PosBRSHFEJl50Y3XwmaNoSoh/l4X5VMzELrfE 4u8Jj6zEcdzl0SlUVybxyw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qDkhi-0002Pp-Ek; Mon, 26 Jun 2023 07:48:23 -0400 In-Reply-To: <87leg6v9yg.fsf@gmx.net> (message from Stephen Berman on Mon, 26 Jun 2023 11:39:35 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264091 Archived-At: > From: Stephen Berman > Date: Mon, 26 Jun 2023 11:39:35 +0200 > > This report describes and provides patches for four different bugs in > todo-mode.el. Three of the bugs can result in todo-mode file format > corruption, and the fourth is a documentation bug, so I think the fixes > should all be installed in the release branch, and I'm asking for > permission to do that. As with my previous todo-mode bugfix, which also > went into the release branch (bug#63811), the patches touch only > todo-mode.el and with them all todo-mode unit tests pass. The 3rd and the 4th patches are okay for the release branch. The first one looks OK, but how sure you are that you have identified all the places which need buffer-read-only bound to nil? Did you exercise all the possible code paths in the places affected by this change? The 2nd patch is the scariest. How grave is it, and if it's grave, how come it was not reported until now? In general, I'd prefer to have the 2nd patch on master, not on the release branch, at least for now. (We could consider backporting it after Emacs 29.1 is released.) Thanks.