From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64311: [PATCH] Fix shell-dirtrack-mode showing up as enabled in unrelated buffers Date: Fri, 30 Jun 2023 08:40:12 +0300 Message-ID: <835y75tsn7.fsf@gnu.org> References: <87pm5h4iy1.fsf@t510.orion.oneofus.la> <83h6qtw3tq.fsf@gnu.org> <87wmzp2e0d.fsf@t510.orion.oneofus.la> <831qhwx5qf.fsf@gnu.org> <87zg4k76es.fsf@orphne.orion.oneofus.la> <83mt0jvmfu.fsf@gnu.org> <87r0pva66g.fsf@t510.orion.oneofus.la> <834jmrv3p6.fsf@gnu.org> <87o7kz9wej.fsf@t510.orion.oneofus.la> <83wmzmuaq7.fsf@gnu.org> <87wmzmb5fl.fsf@t510.orion.oneofus.la> <83a5wita0p.fsf@gnu.org> <87ttuqax6d.fsf@t510.orion.oneofus.la> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64311@debbugs.gnu.org To: Vladimir Sedach Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 30 07:41:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qF6sr-0004ub-4s for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jun 2023 07:41:29 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qF6sV-0006bk-5Q; Fri, 30 Jun 2023 01:41:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF6sQ-0006bE-8g for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 01:41:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qF6sP-00052T-WF for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 01:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qF6sP-0006cs-Qu for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 01:41:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2023 05:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64311 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64311-submit@debbugs.gnu.org id=B64311.168810360525382 (code B ref 64311); Fri, 30 Jun 2023 05:41:01 +0000 Original-Received: (at 64311) by debbugs.gnu.org; 30 Jun 2023 05:40:05 +0000 Original-Received: from localhost ([127.0.0.1]:54364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF6rU-0006bH-Ne for submit@debbugs.gnu.org; Fri, 30 Jun 2023 01:40:05 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:51090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF6rS-0006ah-88 for 64311@debbugs.gnu.org; Fri, 30 Jun 2023 01:40:03 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF6rM-0004Sm-LI; Fri, 30 Jun 2023 01:39:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qCgkoHl9Z6zpjZ5IiewgBDOoyog3MUsyzfnrnmhqs3Q=; b=BYnGBCNJ21Ce uegDOroC/QlzVUGIFmTsYYG+gvWIpvD10PCWmSNjm9LznbQTBG83Llr+aSBSgwCqiYGLsE1yL/yeb Cj4RyNg7CDdrtCdB24D2lw9VqV6G6uc0tPMq7VwPbcHR7607gGpzqb441MVaCo3tm6H0fh4QJN7Dk aZ3dk6jEZWOnWbGKkVz6gn5PsFWXYJsmeaC2RN+IFy1O295AuLDWkXgiL+TIRzccLXax3fG8r3SIh P4NJ3GR1hoeQBNwiNQYwUvqduMDFa/cFvVKuZJ4ZLhhhnExuDHIXd9XL5+8Y5V60be8QFfKiymG+h P5Uq75xIgz75OgMbA3i16A==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF6r8-0005UY-VK; Fri, 30 Jun 2023 01:39:50 -0400 In-Reply-To: <87ttuqax6d.fsf@t510.orion.oneofus.la> (message from Vladimir Sedach on Thu, 29 Jun 2023 13:24:58 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264302 Archived-At: > From: Vladimir Sedach > Cc: 64311@debbugs.gnu.org > Date: Thu, 29 Jun 2023 13:24:58 -0600 > > > Eli Zaretskii writes: > > > Am I? Asking about the root cause of the problem is not wrong, > > because it indicates how best to fix it. > > The root cause of the problem is the redundant variable > shell-dirtrackp, not its value. It is the variable aliasing in the > 2018 commit 9c3eeba4db26ddaeead100beea7a96f9fa640918 that introduced > the bug. > > This is why my patch addresses the root cause of the problem, instead > of setting the value of the variable (which commit > 9c3eeba4db26ddaeead100beea7a96f9fa640918 did not touch). The variable's existence is only the cause of the problem because of its value. > > Why would we bother about that? With the exception of the default > > value, what harm does that variable cause by existing? > > It is misleading for someone trying to customize shell-mode, or work > on shell.el. I found it confusing on both counts. Such confusion can be prevented by adding appropriate comments. By contrast, removing the variable, or declaring it obsolete, is backward-incompatible change in behavior, which we try to avoid at all costs. In this case, I see absolutely no justification for such backward incompatibility. We wouldn't be able to defend such a change if it caused someone annoyance or, worse, breakage of their Emacs setup and usage. > If it were not confusing for you too, we obviously would not be > having such a long back-and-forth conversation about this bug. The discussion was long because I couldn't connect between the problem and the changes you proposed. The solution I thought about immediately was just to change the value of the variable. The rest was getting you to agree that such a change would indeed solve the problem (although you disagree it's the right solution).