From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65186: 29.0.91; `dired-free-space' is a step backward Date: Thu, 10 Aug 2023 20:43:55 +0300 Message-ID: <835y5miyhw.fsf@gnu.org> References: <83sf8rjuhu.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40771"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65186-done@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 10 19:44:56 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qU9iS-000ALm-EY for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 10 Aug 2023 19:44:56 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qU9hj-0007Qn-BB; Thu, 10 Aug 2023 13:44:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU9he-00077Y-7G for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 13:44:08 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qU9ha-0005Ap-PQ for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 13:44:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qU9ha-00039q-BE for bug-gnu-emacs@gnu.org; Thu, 10 Aug 2023 13:44:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 10 Aug 2023 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65186 X-GNU-PR-Package: emacs Mail-Followup-To: 65186@debbugs.gnu.org, eliz@gnu.org, drew.adams@oracle.com Original-Received: via spool by 65186-done@debbugs.gnu.org id=D65186.169168941812094 (code D ref 65186); Thu, 10 Aug 2023 17:44:02 +0000 Original-Received: (at 65186-done) by debbugs.gnu.org; 10 Aug 2023 17:43:38 +0000 Original-Received: from localhost ([127.0.0.1]:43984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU9hC-000390-2V for submit@debbugs.gnu.org; Thu, 10 Aug 2023 13:43:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36050) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qU9h7-00038l-Un for 65186-done@debbugs.gnu.org; Thu, 10 Aug 2023 13:43:36 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qU9h2-00057U-KG; Thu, 10 Aug 2023 13:43:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3dcsTvaHpyCmtTDgNzSrIU/wmgKXfc7zZ5EbU50k+Ss=; b=Pv1y/hpqIwo+ dn7bA1jA2Qy5IovJSxdBjFSC1Px9Tg17HtIuMRgTicZKJt6QI0hrPKZJARGIhRTl9mFqDguCLrcWG V90GyZ9yTJLUZJ3cBrAQ1OzRBiW1FUCO2Je/hcCi9WIfZ/tyc/ckdEt6reYCDmNgoLEXftPKyFG9P 4MaVlXM7AYaa/t6K3knOnyzz1xsnRBBUgVvIf+T/VJIkVuJzEe3Ledlw1bB6YtVNUbAHVgHgbt804 9i/q+IExwLreI9wHqkfO8L7PaQSAJfTVX6kbWcIx80/fVTloXkdcbz/IF9dBKn7BWmgRzSl+TF04t XMziYjl9dX0aBcEYyb2gdA==; In-Reply-To: (message from Drew Adams on Thu, 10 Aug 2023 15:42:57 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267154 Archived-At: > From: Drew Adams > CC: "65186@debbugs.gnu.org" <65186@debbugs.gnu.org> > Date: Thu, 10 Aug 2023 15:42:57 +0000 > > > > Two main problems with this self-styled enhancement: > > > > > > 1. The default behavior should be what we've always had, which > > > corresponds to NONE of the `dired-free-space' option values. > > > > The 'separate' value (which is not the default) produces the behavior > > we had in Emacs 28 and older, so why do you say that "what we always > > had corresponds to none" of the option's values? > > No, it doesn't. Not with `emacs -Q' on MS Windows (which uses ls-lisp), at least. Not in 28.2 or ANY earlier release, going back to when `dired-hide-details-mode' was first introduced. In all releases, if you use `(' to hide details then that "separate" line is one of the details that's _removed_. If this is about hiding the disk space information, then it's your item 2, and is now fixed. With that taken care of, the 'separate' value produces the disk space display identical to what Emacs 28 and older did. > > > 2. Even if you set the option to `separate', so you see the full info, > > > you can't get the superior previous behavior, which is that there's _no > > > such info_ shown when you hide details (`('). > > > > > > Instead, Someone(TM) maybe thought that those interested in what > > > Someone(TM) doesn't think interesting - the full info - always want to > > > see that info, even with details hidden. Blinders... > > > > I think it was just an oversight, now fixed on the emacs-29 branch. > > Thank you very much, Eli. > (I don't build Emacs, but I'm guessing you mean what I hope you mean. ;-)) The change I installed makes '(' hide the disk space information when it is displayed on a separate line, under dired-free-space = 'separate'. This is for consistency with previous behavior of Dired. > IF all you changed was to make `separate' be the default or IF it was only to hide all such info when hiding details, then that doesn't fix what I'd like to see fixed. 'separate' will not become default. Emacs 29 was already released with a different default, so that ship has sailed. We will only revert back to 'separate' if there will be user outcry to that effect. > 1. The default behavior as it was before: when details aren't hidden, show the full info on a separate line, and when details are hidden, don't show any such info (available, used, etc.). > > 2. For _each_ of the option values: when details are hidden, don't show any such info. (Unless you add a separate option value for something different. At least let users get the old behavior exactly, as one possibility) The default display of the disk space info is on the same line as the directory name. It doesn't get hidden when you press '(', and I'm not sure it should. I made it be hidden for the 'separate' display, because that's how it behaved before Emacs 29, but there's no such precedent for the default value of 'first', and so what you want to happen in that case is just your personal opinion. We don't need to agree about that. And with that, I'm closing this bug.