From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#64989: 29.1; Comment or uncomment lines in elisp-mode will show message in minibuffer Date: Thu, 24 Aug 2023 09:19:41 +0300 Message-ID: <835y55q7wi.fsf@gnu.org> References: <83leeu292j.fsf@gnu.org> <83fs4og3px.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14302"; mail-complaints-to="usenet@ciao.gmane.io" Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org To: monnier@iro.umontreal.ca Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 24 08:20:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qZ3hM-0003Uq-En for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 24 Aug 2023 08:20:04 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qZ3hI-0000VY-Fj; Thu, 24 Aug 2023 02:20:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ3hH-0000Uy-05 for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 02:19:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qZ3hG-00060c-MO for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 02:19:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qZ3hK-00089Y-FT for bug-gnu-emacs@gnu.org; Thu, 24 Aug 2023 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Aug 2023 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64989 X-GNU-PR-Package: emacs Original-Received: via spool by 64989-submit@debbugs.gnu.org id=B64989.169285797131294 (code B ref 64989); Thu, 24 Aug 2023 06:20:02 +0000 Original-Received: (at 64989) by debbugs.gnu.org; 24 Aug 2023 06:19:31 +0000 Original-Received: from localhost ([127.0.0.1]:35970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3go-00088f-Hu for submit@debbugs.gnu.org; Thu, 24 Aug 2023 02:19:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qZ3gl-00088Q-Ve for 64989@debbugs.gnu.org; Thu, 24 Aug 2023 02:19:29 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qZ3ga-0005uI-Qo; Thu, 24 Aug 2023 02:19:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=83m9uC9R9O7v5Hg/mvDHoTJiii0HaMIWy/fUXEiY2Hg=; b=n8815COSVbnj ODFFS5zNeWARB0A147QY6hSGVNKTQ1LqJV12RdV0mLM9XZwxhuHUAusJv1tIq6xwkBqhqIwCSQveZ hZaYm4BvuhnBWWzKcIU3wOrEG3UpcfsfB3G/6n68aVsxyOQxcZ8ZGke4NWL5+m6fejWa1Vy7bWyGg Z0SCzHUtPwDChIWiWYKyfUseHFKf+Hns4IwrglDC2lq89jVrlq02pEHoXj5LVPJ+px9+sAq5dSK85 C7LA2DhX6VD3hRYTxvc95w3i1e76OHGKwtc9GHXCNQ+SoRTLK49W8HfLrYhzUi5Q3JwFryj1se94N gN+SYYCEiAYHhyAUjAkJ9w==; In-Reply-To: <83fs4og3px.fsf@gnu.org> (message from Eli Zaretskii on Sat, 12 Aug 2023 09:43:54 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268307 Archived-At: Ping! Ping! > Cc: aqua0210@foxmail.com, 64989@debbugs.gnu.org > Date: Sat, 12 Aug 2023 09:43:54 +0300 > From: Eli Zaretskii > > Ping! Stefan, any suggestions? > > > Cc: 64989@debbugs.gnu.org > > Date: Tue, 01 Aug 2023 16:20:20 +0300 > > From: Eli Zaretskii > > > > > From: Eason Huang > > > Date: Tue, 01 Aug 2023 19:13:59 +0800 > > > > > > Hello Emacs, > > > > > > When update to the new released Emacs 29.1, I found that when comment or > > > uncomment lines in emacs-lisp-mode will show message in minibuffer as > > > below: > > > ``` > > > combine-change-calls: buffer-undo-list broken > > > ``` > > > Steps to reproduce: > > > 1. create a test.el file with any Elisp code. such as: > > > ``` > > > (message "Test") > > > ``` > > > 2. start emacs and open the test.el file with `emacs -Q ~/test.el` > > > 3. Use C-x C-; (comment-line) to comment the code in test.el > > > 4. Now you will see the message mentioned above. > > > > Thanks. > > > > Stefan, I think this is due to the commit below: > > > > | Author: Stefan Monnier > > | AuthorDate: Fri Jan 13 17:38:04 2023 -0500 > > | Commit: Stefan Monnier > > | CommitDate: Fri Jan 13 17:38:04 2023 -0500 > > | > > | * lisp/subr.el (combine-change-calls-1): Fix bug#60467 > > | > > | Don't stop at timestamps. Strip them for now, to be on the safe side. > > | Don't merge into `master` where we'll use a better fix. > > > > My "partial bisecting" indicates that the bug was introduced between > > Dec 31, 2022 and Jan 31, 2023, and the above is the only commit > > in-between that could matter. > > > > If indeed this is the culprit, can we perhaps backport the "better > > fix" from master to the emacs-29 branch? > > > >