From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Sat, 16 Sep 2023 08:54:32 +0300 Message-ID: <835y4ak6hz.fsf@gnu.org> References: <127B5BEA-A24B-48A3-9827-85B7CDB67D10@secure.kjonigsen.net> <5f823f8f-d249-f4a1-71e6-083e47d0d123@gutov.dev> <83jztbeeh2.fsf@gnu.org> <03415a27-f082-b204-cece-19a9859e178d@gutov.dev> <8334zze5l4.fsf@gnu.org> <1363c54f-5109-f000-3333-78d291b2096d@gutov.dev> <2D516F0C-D7A8-49D2-8009-F911EFC55C78@secure.kjonigsen.net> <2f525ebe-74e5-dcbe-4403-5e9ae001795c@gutov.dev> <5e57b91b-2967-d82d-eca5-65dc206887cf@gutov.dev> <16E4F60E-5216-457F-A79F-F8FBB5A01D61@secure.kjonigsen.net> <6638462f-89fe-97c4-f008-27e1e2415d2b@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17745"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, 65470@debbugs.gnu.org, theo@thornhill.no, jostein@secure.kjonigsen.net, btuin@mailo.com, jostein@kjonigsen.net To: Dmitry Gutov , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 07:55:08 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhOGq-0004NS-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 07:55:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhOGe-00059d-R4; Sat, 16 Sep 2023 01:54:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhOGd-00059T-JW for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 01:54:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhOGd-0002fR-Bn for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 01:54:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhOGk-0002NC-1K for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 01:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 05:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.16948436979109 (code B ref 65470); Sat, 16 Sep 2023 05:55:02 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 16 Sep 2023 05:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:45228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhOGe-0002Mq-Nx for submit@debbugs.gnu.org; Sat, 16 Sep 2023 01:54:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhOGb-0002MY-HT for 65470@debbugs.gnu.org; Sat, 16 Sep 2023 01:54:55 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhOGN-0002c2-Sx; Sat, 16 Sep 2023 01:54:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=X1RPKOfT8MNnZ2Kr7sOn3uA0Ltri+huVMnksIYIilHU=; b=DvcJ+IN4UjpKZTo2g/Cj orkajFiSow8fWVlFv8DiQCL0Kd460ptbHdzu+GdPe2gyv9QPgBDl77ctHvqZKxVK1g+C4bv5DqWyM 6I/14/80M/WdCX4mNXBQfnL7b5Q8UVeEpu+CTiKEJzODNqRPiEpt8hqmaVUIxlN02A1qHeomjM1HG +WJxwdgVpCB111739e52SObtmsH0X6AgOzU+3a+M1kFD7cf47X/MUZSZYUbAm0xDqR+3SMKCRJ/p0 CNsn7xhhm9snbWZorna/t3Y9u0c11FpeGruK3MyBLDSspZm1ku6PHUcm+gsmg+yqC6bwahQjqshxA pQcradN6f/MIQA==; In-Reply-To: <6638462f-89fe-97c4-f008-27e1e2415d2b@gutov.dev> (message from Dmitry Gutov on Fri, 15 Sep 2023 16:35:55 +0300) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270577 Archived-At: > Date: Fri, 15 Sep 2023 16:35:55 +0300 > Cc: Eli Zaretskii , Yuan Fu , > Theodor Thornhill , > Jostein Kjønigsen , btuin@mailo.com, > 65470@debbugs.gnu.org > From: Dmitry Gutov > > On 15/09/2023 15:11, Jostein Kjønigsen wrote: > >> This patch seems to fix that and bring JSX syntax highlighting back: > >> > >> diff --git a/lisp/progmodes/typescript-ts-mode.el b/lisp/progmodes/typescript-ts-mode.el > >> index 57382c9cb31..7108ff49b28 100644 > >> --- a/lisp/progmodes/typescript-ts-mode.el > >> +++ b/lisp/progmodes/typescript-ts-mode.el > >> @@ -163,7 +163,7 @@ tsx-ts-mode--font-lock-compatibility-bb1f97b > >> ;; but then raises an error if the wrong node type is used. So it is > >> ;; important to check with the new node type (member_expression) > >> (condition-case nil > >> - (progn (treesit-query-capture language '((member_expression) @capture)) > >> + (progn (treesit-query-capture language '(jsx_opening_element (member_expression) @capture)) > >> '((jsx_opening_element > >> [(member_expression (identifier)) (identifier)] > >> @typescript-ts-jsx-tag-face) > >> > > I really don’t know this part of the code very well. If you’ve identified an issue/bug for a specific TSX use-case, and found a fix for it, I have no objections to it being applied. > > No problem, pushed that to emacs-29, thanks. This seems to cause: INFO Scraping files for loaddefs...85% typescript-ts-mode:0: Warning: Not registering prefix "ts". Affects: ("tsx-ts-mode--indent-compatibility-b893426" "tsx-ts-mode--font-lock-compatibility-bb1f97b" "tsx-ts--s-p-query" "tsx-ts--syntax-propertize" "ts-ts--s-p-query" "ts-ts--syntax-propertize" "ts-ts--syntax-propertize-captures") Stefan, what do we usually do with such warnings?