From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65902: 29.0.92; emacsclient-mail.desktop fails due to complicated escaping Date: Fri, 22 Sep 2023 09:36:16 +0300 Message-ID: <835y4290kf.fsf@gnu.org> References: <80d8aeb0-c9f1-410f-b83d-60f83ca5b3af@email.android.com> <83led8ls3z.fsf@gnu.org> <835y4ckkzu.fsf@gnu.org> <874jjnvvip.fsf@catern.com> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14025"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65902@debbugs.gnu.org, sbaugh@janestreet.com, jporterbugs@gmail.com To: sbaugh@catern.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 08:37:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjZms-0003PM-G5 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 08:37:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjZmZ-0006rm-D9; Fri, 22 Sep 2023 02:36:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjZmW-0006rZ-An for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 02:36:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjZmW-0000u7-2L for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 02:36:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjZmf-0007df-UM for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 02:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 06:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65902 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65902-submit@debbugs.gnu.org id=B65902.169536459029322 (code B ref 65902); Fri, 22 Sep 2023 06:37:01 +0000 Original-Received: (at 65902) by debbugs.gnu.org; 22 Sep 2023 06:36:30 +0000 Original-Received: from localhost ([127.0.0.1]:35165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjZm9-0007cs-K7 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 02:36:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjZm4-0007cb-Gn for 65902@debbugs.gnu.org; Fri, 22 Sep 2023 02:36:28 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjZln-0000qx-GV; Fri, 22 Sep 2023 02:36:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ROs92ADmxFEUQ+1opgH4Dr6BcT+YwqtqbP1ZhS6957I=; b=sNT4tzNnLbsi uneqn5n3mWfR5HT9mzkd1vWModfIVu0XKVXBZmHu82V8wdO1WGhANeMAxEFq9ve0KZOTFPCOYkhui 94IjaiNQcpIC861hO7p8AKPyqe+0sBcQT6MrttOEi+8ecT6exWsNeYBap2MZIGSYkIZPdeaLy12jC WnzWJWsrjrgml5VGdXmZZX4QQeamn2mSomMIgpGtnzk/4dUjwGnnIjSXGuKKN6Qp/5JAP/LSXfwNO UMyXarfqyjdNw6PAh0aNc+MshFK4zgHU132SrT8QjTCvdFhLwetBZ4BE/uosqar8qzeQ2KY6xIMnb NXPRsbIQJoYtmtA9VtL0Wg==; In-Reply-To: <874jjnvvip.fsf@catern.com> (sbaugh@catern.com) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271037 Archived-At: > From: sbaugh@catern.com > Date: Fri, 22 Sep 2023 01:36:47 +0000 (UTC) > Cc: Spencer Baugh , jporterbugs@gmail.com, > 65902@debbugs.gnu.org > > > Currently, when emacsclient is invoked like this: > > > > $ emacsclient --eval '(func args)' foo bar > > > > we send to the server the following commands: > > > > -eval (func args) > > -eval foo > > -eval bar > > > > IOW, every command-line argument after --eval is treated as being > > implicitly preceded with --eval. > > > > With your proposal, how will the server know that some of "-eval foo" > > commands should cause foo to be added to server-eval-args-left instead > > of being evaluated as it does now? > > As in the attached patch. I wish you'd accompanied the patch with some plain-text description of the idea, to make it easier to understand and to avoid unnecessary misunderstandings. IIUC, this kind of solution is fine by me, but the protocol of accessing and using server-eval-args-left in the Lisp expressions specified on the emacsclient command line should be well-documented to avoid any confusion and UB. Also, the patch includes an unrelated change: > --- a/lisp/server.el > +++ b/lisp/server.el > @@ -1165,7 +1165,7 @@ server-process-filter > (when prev > (setq string (concat prev string)) > (process-put proc 'previous-string nil))) > - (condition-case err > + (condition-case-unless-debug err