From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: dmitry@gutov.dev, acm@muc.de, 67568-done@debbugs.gnu.org
Subject: bug#67568: Emacs master: Bug in byte compiler when there's an unused parameter.
Date: Sun, 03 Dec 2023 21:28:01 +0200 [thread overview]
Message-ID: <835y1f6q7y.fsf@gnu.org> (raw)
In-Reply-To: <jwvedg3gkfg.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Sun, 03 Dec 2023 14:24:44 -0500)
> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: acm@muc.de, 67568-done@debbugs.gnu.org, dmitry@gutov.dev
> Date: Sun, 03 Dec 2023 14:24:44 -0500
>
> >> I'm wondering whether it should go to `emacs-29` or to `master`.
> >> I'm leaning toward `emacs-29` because it's rather embarrassing (and
> >> perplexing for the user) and the patch is simple.
> >> Eli? Stefan?
> > No objections from me.
>
> It turns out the bug is not present in `emacs-29`, it was introduced on
> master by:
>
> commit f616edb4ccce5b9d60e3ff42806bd2131989cd1e
> Author: Mattias Engdegård <mattiase@acm.org>
> Date: Mon Sep 25 14:40:11 2023 +0200
>
> macroexp-parse-body: correct parsing of empty body (bug#66136)
>
> * lisp/emacs-lisp/macroexp.el (macroexp-parse-body):
> Return an empty body even when there are declarations present.
> Previously, the last declaration was considered part of the body,
> which is only correct if the input consists of a single string.
>
> Reported by Jens Schmidt.
>
> So I pushed a better fix, on master.
Great, thanks.
prev parent reply other threads:[~2023-12-03 19:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 12:49 bug#67568: Emacs master: Bug in byte compiler when there's an unused parameter Alan Mackenzie
2023-12-01 13:06 ` Dmitry Gutov
2023-12-01 14:16 ` Alan Mackenzie
2023-12-01 15:22 ` Alan Mackenzie
2023-12-01 15:40 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-01 16:34 ` Alan Mackenzie
2023-12-03 15:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 16:21 ` Eli Zaretskii
2023-12-03 19:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-03 19:28 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y1f6q7y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=67568-done@debbugs.gnu.org \
--cc=acm@muc.de \
--cc=dmitry@gutov.dev \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).