From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67687: Feature request: automatic tags management Date: Thu, 21 Dec 2023 09:40:09 +0200 Message-ID: <835y0sgg12.fsf@gnu.org> References: <2f86b882-9ec1-f63f-d90b-5f8f7ae114f2@gutov.dev> <58D84A29-9A63-45BA-AD8B-B476CDC931A1@gmail.com> <812729c8-726f-d60e-2603-2d8e588929fd@gutov.dev> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40770"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67687@debbugs.gnu.org, eskinjp@gmail.com, stefankangas@gmail.com To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 21 08:41:31 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rGDgO-000AMY-EC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Dec 2023 08:41:28 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rGDfw-0003wq-8d; Thu, 21 Dec 2023 02:41:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGDfu-0003wX-MR for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 02:40:58 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rGDfu-0000tp-DW for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 02:40:58 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rGDfx-0007I5-Qy for bug-gnu-emacs@gnu.org; Thu, 21 Dec 2023 02:41:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Dec 2023 07:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67687 X-GNU-PR-Package: emacs Original-Received: via spool by 67687-submit@debbugs.gnu.org id=B67687.170314444928000 (code B ref 67687); Thu, 21 Dec 2023 07:41:01 +0000 Original-Received: (at 67687) by debbugs.gnu.org; 21 Dec 2023 07:40:49 +0000 Original-Received: from localhost ([127.0.0.1]:42319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGDfk-0007HY-LZ for submit@debbugs.gnu.org; Thu, 21 Dec 2023 02:40:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rGDfg-0007HK-J3 for 67687@debbugs.gnu.org; Thu, 21 Dec 2023 02:40:47 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rGDfV-0000rJ-E9; Thu, 21 Dec 2023 02:40:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZkSIQ5P9xo/nXGT9SCzm4uG56GmKk52O/qBYbRo03XA=; b=PLVWJheYrHqa /ecA0bUkGQKyR1Bb688TdWZhzCZT/dxOXqLexBOX1EJLj7FMupoP7qtjDH+FxHx54SPSOQALy8wFP cIPD8N6Z+8Zv0JyacNi0k4az/T3GHt3HQSMq4xtpsa9TVTUzeKs42O1rc8FJJRxAx5rWvj9zARMa1 5bvUE2YhaRi7eVYJVvvH3eGz0ZR9DF1TiTID9KmC66aKV8iUdxZxZqORiwSIF8pswRYq0SFj7C0I4 eBRC+k9zick7r8COySZ+Rj8EGCeyCuCY7t06AyUzm6xXhDb1mJ/p+S+LRqQn1ZR2wuuhc4zX0DrHc LvV+DqRmltL/JzTK4Jm1XQ==; In-Reply-To: <812729c8-726f-d60e-2603-2d8e588929fd@gutov.dev> (message from Dmitry Gutov on Thu, 21 Dec 2023 02:24:01 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276614 Archived-At: > Date: Thu, 21 Dec 2023 02:24:01 +0200 > Cc: 67687@debbugs.gnu.org > From: Dmitry Gutov > > That is a good sign (with another positive bit of feedback on Reddit > yesterday), so I think it's time to ask the head maintainers what they > think about the inclusion of this feature in the core now. > > Eli/Stefan? I didn't hear about any disadvantages; are there any issues we need to consider? Does the etags test suite still pass after these changes? Some comments based on a superficial look at the branch: . there are no updates for NEWS and the Emacs manual . the doc string of etags-regen-mode should explain more about what it does . the new -L switch to etags is not mentioned in --help and in the man page of etags . defcustoms don't have a :version tag . etags-regen-lang-regexp-alist could have a shorter name: etags-regen-regexp-alist, and its doc string should describe the form of the alist . in the safe-local-variable form of etags-regen-lang-regexp-alist, why do we force the language name to match a certain regexp, and likewise with extensions in etags-regen-file-extensions? . the shell command in etags-regen--all-mtimes is non-portable: it needs xargs and stat commands; please use directory-files-recursively with file-attributes instead, at least as fallback . I see several FIXMEs and TODOs in the code . I wonder whether we should make sure etags supports the new -L switch, and signal an error if not -- since you invoke etags via PATH, it is quite possible to invoke an older version, the one installed on the system, and not the one in the repository, as long as Emacs 30 is not installed . why does etags-regen--tags-generate require 'dired? . why do we have to use advice-add/remove in etags-regen-mode? can't we add hooks to the relevant functions instead? . you are removing a project-files method from project.el -- isn't that backward-incompatible? Thanks.