From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Jensen <aaronjensen@gmail.com>
Cc: 68083@debbugs.gnu.org, acorallo@gnu.org, jschmidt4gnu@vodafonemail.de
Subject: bug#68083: 30.0.50; Intermittent build failure with native compilation
Date: Sat, 30 Dec 2023 08:47:43 +0200 [thread overview]
Message-ID: <835y0g5gq8.fsf@gnu.org> (raw)
In-Reply-To: <CAHyO48w70nWDXY2T+Nvw-aO5AqESbzAG5cdWk0iJrmRFdib9yw@mail.gmail.com> (message from Aaron Jensen on Fri, 29 Dec 2023 16:07:38 -0500)
> From: Aaron Jensen <aaronjensen@gmail.com>
> Date: Fri, 29 Dec 2023 16:07:38 -0500
> Cc: Eli Zaretskii <eliz@gnu.org>, 68083@debbugs.gnu.org,
> Jens Schmidt <jschmidt4gnu@vodafonemail.de>
>
> Just to confirm, adding macroexpand to native-comp-never-optimize-functions allows me to build
> successfully.
>
> It also looks like comp-delete-or-replace-file can be updated to protect rename-file against
> file-already-exists like it does for Windows. That would also likely solve the problem if you want to be
> able to optimize macroexpand.
Are you sure? We do that on Windows because Windows doesn't allow us
to delete a file that is open by another program. That shouldn't
happen on Posix systems, so I think what you see here is due to a race
between checking whether a file exists and renaming it, which is a
different problem.
However, feel free to try the same trick we use on Windows and see
whether it helps.
next prev parent reply other threads:[~2023-12-30 6:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 14:05 bug#68083: 30.0.50; Intermittent build failure with native compilation Aaron Jensen
2023-12-28 15:12 ` Eli Zaretskii
2023-12-29 18:43 ` Andrea Corallo
2023-12-29 19:09 ` Aaron Jensen
2023-12-29 20:17 ` Andrea Corallo
2023-12-29 20:26 ` Aaron Jensen
2023-12-29 21:07 ` Aaron Jensen
2023-12-30 6:47 ` Eli Zaretskii [this message]
2023-12-30 15:29 ` Aaron Jensen
2023-12-30 17:42 ` Eli Zaretskii
2023-12-30 18:06 ` Aaron Jensen
2023-12-30 18:46 ` Eli Zaretskii
2023-12-30 20:54 ` Aaron Jensen
2023-12-30 23:08 ` Aaron Jensen
2023-12-31 6:26 ` Eli Zaretskii
2024-01-01 19:39 ` Andrea Corallo
2024-01-01 20:12 ` Eli Zaretskii
2023-12-31 20:30 ` Jens Schmidt via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=835y0g5gq8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=68083@debbugs.gnu.org \
--cc=aaronjensen@gmail.com \
--cc=acorallo@gnu.org \
--cc=jschmidt4gnu@vodafonemail.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).