unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 68428@debbugs.gnu.org
Subject: bug#68428: 29.1.90; info-xref-tests fails
Date: Mon, 15 Jan 2024 15:32:10 +0200	[thread overview]
Message-ID: <835xzuen8l.fsf@gnu.org> (raw)
In-Reply-To: <87r0ii6c54.fsf@gmx.de> (message from Michael Albinus on Mon, 15 Jan 2024 12:59:03 +0100)

> From: Michael Albinus <michael.albinus@gmx.de>
> Cc: 68428@debbugs.gnu.org
> Date: Mon, 15 Jan 2024 12:59:03 +0100
> 
> Well, finally it is another bug. It is in function
> info-xref-subfile-p. This function tries to determine, whether a given
> file is an info subfile.
> 
> My emacs-29 branch is checked out in directory /home/albinus/src/emacs-29.
> So there is, for example, a call of
> 
> (info-xref-subfile-p "/home/albinus/src/emacs-29/info/auth.info")
> 
> The function tries to decompose the filename via the regexp
> "\\`\\(\\([^-]*-\\)*[^-]*\\)-[0-9]+\\(.*\\)\\'". This succeeds, and
> returns
> 
> (match-string 1 filename) => "/home/albinus/src/emacs"
> (match-string 3 filename) => "/info/auth.info"
> 
> This is wrong. string-match should return nil according to the
> intention. And the call of
> 
> (file-exists-p "/home/albinus/src/emacs/info/auth.info")
> 
> succeeds also, because my Emacs master branch is located in
> /home/albinus/src/emacs, and therefore
> "/home/albinus/src/emacs/info/auth.info" does exist.

Can you explain why you see the bug and I don't?  What exactly
triggers the bug, and why didn't we uncover it until now?

> The appended patch fixes this. Shall I install it in the emacs-29 or the
> master branch?

On master, please.  But first I'd like to understand the bug better.

Thanks.





  reply	other threads:[~2024-01-15 13:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-13 16:08 bug#68428: 29.1.90; info-xref-tests fails Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-13 18:42 ` Eli Zaretskii
2024-01-14 10:25   ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-14 10:41     ` Eli Zaretskii
2024-01-15 11:59     ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15 13:32       ` Eli Zaretskii [this message]
2024-01-15 13:40         ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-15 14:03           ` Eli Zaretskii
2024-01-15 15:57             ` Michael Albinus via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=835xzuen8l.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=68428@debbugs.gnu.org \
    --cc=michael.albinus@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).