unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: arnima@hafro.is, 11067@debbugs.gnu.org
Subject: bug#11067: 24.0.94.1; diff-buffer-with-file
Date: Sat, 24 Mar 2012 08:13:56 +0200	[thread overview]
Message-ID: <834ntev84b.fsf@gnu.org> (raw)
In-Reply-To: <jwvehsikbqz.fsf-monnier+emacs@gnu.org>

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Fri, 23 Mar 2012 21:53:57 -0400
> Cc: 11067@debbugs.gnu.org
> 
> > http://alpha.gnu.org/gnu/emacs/windows/emacs-20120319-r107630-bin-i386.zip
> > and `diff-buffer-with-file' is not working like it did in Emacs 23.4.1
> > 1. Start emacs -Q
> > 2. Set `diff-command' to "winmerge" and `diff-switches' to nil
> 
> It seems that's your problem: winmerge is not a replacement for `diff'
> because it does not accept the "-L <label>" argument of diff.

Actually, winmerge _is_ a valid replacement, because it includes GNU
Diff as its part.  It's just that it doesn't know about -L, and
rightfully so, since that switch is undocumented in many versions of
Diff.

Regardless, I think it's obnoxious on the part of Emacs to stick
literal switches into a command without either (a) probing that the
command does indeed accept them, or (b) giving the user an opportunity
to customize these switches.





  parent reply	other threads:[~2012-03-24  6:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-22 14:54 bug#11067: 24.0.94.1; diff-buffer-with-file Arni Magnusson
2012-03-23 21:34 ` Glenn Morris
2012-03-23 21:39   ` Glenn Morris
2012-03-24  1:49   ` Stefan Monnier
2012-03-24  6:15     ` Eli Zaretskii
2012-03-24 18:27     ` Glenn Morris
2012-03-24 21:12       ` Paul Eggert
2012-03-25  3:23         ` Stefan Monnier
2013-02-11  8:29           ` Glenn Morris
2012-03-24  1:53 ` Stefan Monnier
2012-03-24  2:28   ` Arni Magnusson
2012-03-24  6:13   ` Eli Zaretskii [this message]
2012-03-24 18:19 ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=834ntev84b.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=11067@debbugs.gnu.org \
    --cc=arnima@hafro.is \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).