From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: 13054@debbugs.gnu.org
Subject: bug#13054: Assume POSIX 1003.1-1988 or later for execve.
Date: Sun, 02 Dec 2012 19:03:39 +0200 [thread overview]
Message-ID: <834nk4tmhg.fsf@gnu.org> (raw)
In-Reply-To: <50BADB13.1040301@cs.ucla.edu>
> Date: Sat, 01 Dec 2012 22:37:39 -0600
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: Eli Zaretskii <eliz@gnu.org>
>
> Attached is a patch to simplify Emacs that I discovered while looking
> into the putenv/setenv problem. It affects the NT port so I'm
> CC'ing this to Eli to give him a heads-up.
Thanks. You can go ahead and commit this, these changes don't affect
MS-Windows at all (except in trivial "a = b; b = a;" way, without
changing a or b in between).
However, please omit these changes from the changeset:
> === modified file 'lib-src/ntlib.h'
> --- lib-src/ntlib.h 2012-01-19 07:21:25 +0000
> +++ lib-src/ntlib.h 2012-12-02 04:32:26 +0000
> @@ -79,6 +79,7 @@
>
> /* map to MSVC names */
> #define execlp _execlp
> +#define execve _execve
> #define execvp _execvp
> #define fdopen _fdopen
> #ifndef fileno
> @@ -104,4 +105,3 @@
> #undef _WINSOCK_H
>
> /* end of ntlib.h */
> -
>
> === modified file 'nt/ChangeLog'
> --- nt/ChangeLog 2012-12-01 20:09:30 +0000
> +++ nt/ChangeLog 2012-12-02 04:32:26 +0000
> @@ -1,3 +1,8 @@
> +2012-12-02 Paul Eggert <eggert@cs.ucla.edu>
> +
> + Assume POSIX 1003.1-1988 or later for execve.
> + * inc/ms-w32.h (execve): New macro.
> +
> 2012-12-01 Juanma Barranquero <lekktu@gmail.com>
>
> * config.nt: Sync with autogen/config.in.
>
> === modified file 'nt/inc/ms-w32.h'
> --- nt/inc/ms-w32.h 2012-11-27 03:10:32 +0000
> +++ nt/inc/ms-w32.h 2012-12-02 04:32:26 +0000
> @@ -204,6 +204,7 @@
>
> /* Map to MSVC names. */
> #define execlp _execlp
> +#define execve _execve
> #define execvp _execvp
> #define fdopen _fdopen
> #ifndef fileno
>
They are not needed. (The Windows build of Emacs doesn't use any
functions of the exec* family, because they are fundamentally broken
on Windows. I will look into removing the other exec* macros from
Windows-specific files.)
prev parent reply other threads:[~2012-12-02 17:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-02 4:37 bug#13054: Assume POSIX 1003.1-1988 or later for execve Paul Eggert
2012-12-02 8:27 ` Andreas Schwab
2012-12-02 18:17 ` Paul Eggert
2012-12-02 18:48 ` Andreas Schwab
2012-12-02 19:19 ` Paul Eggert
2012-12-02 21:10 ` Andreas Schwab
2012-12-02 17:03 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=834nk4tmhg.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=13054@debbugs.gnu.org \
--cc=eggert@cs.ucla.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).