From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15886: 24.3.50; Incorrect window-text-height with non-zero line-spacing Date: Wed, 13 Nov 2013 23:16:22 +0200 Message-ID: <834n7g0zq1.fsf@gnu.org> References: <8D614196-65E4-4F20-AAFE-CCFDC32D9898@robertdallasgray.com> <83a9h811r7.fsf@gnu.org> <4D2C9983-9E63-44F6-83A6-3D306B9EC79C@robertdallasgray.com> <837gcc116m.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1384377438 29287 80.91.229.3 (13 Nov 2013 21:17:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 13 Nov 2013 21:17:18 +0000 (UTC) Cc: 15886@debbugs.gnu.org To: Robert Dallas Gray Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 13 22:17:22 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VghoN-0007jm-SY for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2013 22:17:20 +0100 Original-Received: from localhost ([::1]:50861 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghoN-00028v-4g for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Nov 2013 16:17:19 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VghoE-00027m-Gb for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2013 16:17:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vgho6-0006ZY-Pf for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2013 16:17:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vgho6-0006ZU-MH for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2013 16:17:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vgho6-0002Rm-6S for bug-gnu-emacs@gnu.org; Wed, 13 Nov 2013 16:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Nov 2013 21:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15886 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15886-submit@debbugs.gnu.org id=B15886.13843773989368 (code B ref 15886); Wed, 13 Nov 2013 21:17:02 +0000 Original-Received: (at 15886) by debbugs.gnu.org; 13 Nov 2013 21:16:38 +0000 Original-Received: from localhost ([127.0.0.1]:50636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vghni-0002R2-2D for submit@debbugs.gnu.org; Wed, 13 Nov 2013 16:16:38 -0500 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:62456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vghnf-0002Qn-Js for 15886@debbugs.gnu.org; Wed, 13 Nov 2013 16:16:36 -0500 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MW800B0006UAC00@a-mtaout22.012.net.il> for 15886@debbugs.gnu.org; Wed, 13 Nov 2013 23:16:29 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MW800BJF0FH8M40@a-mtaout22.012.net.il>; Wed, 13 Nov 2013 23:16:29 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:80388 Archived-At: > From: Robert Dallas Gray > Date: Wed, 13 Nov 2013 20:55:20 +0000 > Cc: 15886@debbugs.gnu.org > > Well, it's not my library, but the reason it fails (in my setup, where I have line-spacing set to 2), is that it tries to set the height of the minibuffer using 'set-window-text-height' -- which, in my setup, sets the height incorrectly (the bottom of the minibuffer is obscured). I note that 'set-window-text-height' uses 'window-text-height' The argument passed to 'set-window-text-height' should be scaled by the ratio of the values returned by 'frame-char-height' and 'default-line-height'. (By default, this ratio is 1, but in your case it will be different.) The result of scaling should then be rounded up to the nearest integer.