From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#22383: 25.1.50; Wrong font height for some fonts Date: Sat, 16 Jan 2016 10:11:54 +0200 Message-ID: <834meeeyet.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1452932001 18419 80.91.229.3 (16 Jan 2016 08:13:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jan 2016 08:13:21 +0000 (UTC) Cc: 22383@debbugs.gnu.org To: Fangwen Yu , Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 16 09:13:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aKLyw-0003nZ-6U for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jan 2016 09:13:10 +0100 Original-Received: from localhost ([::1]:50051 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKLyv-0001fx-EJ for geb-bug-gnu-emacs@m.gmane.org; Sat, 16 Jan 2016 03:13:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKLyq-0001bf-UQ for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2016 03:13:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKLyn-0008MW-OB for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2016 03:13:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKLyn-0008MS-LN for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2016 03:13:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aKLyn-0001YN-HQ for bug-gnu-emacs@gnu.org; Sat, 16 Jan 2016 03:13:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jan 2016 08:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22383 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22383-submit@debbugs.gnu.org id=B22383.14529319275905 (code B ref 22383); Sat, 16 Jan 2016 08:13:01 +0000 Original-Received: (at 22383) by debbugs.gnu.org; 16 Jan 2016 08:12:07 +0000 Original-Received: from localhost ([127.0.0.1]:50427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aKLxv-0001XB-DN for submit@debbugs.gnu.org; Sat, 16 Jan 2016 03:12:07 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:38036) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aKLxt-0001Wi-9x for 22383@debbugs.gnu.org; Sat, 16 Jan 2016 03:12:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKLxn-00089o-AN for 22383@debbugs.gnu.org; Sat, 16 Jan 2016 03:12:00 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59507) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKLxj-00085t-HK; Sat, 16 Jan 2016 03:11:55 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1931 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aKLxi-0007lr-Jg; Sat, 16 Jan 2016 03:11:54 -0500 In-reply-to: (message from Fangwen Yu on Sat, 16 Jan 2016 15:07:04 +0800) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111668 Archived-At: > Date: Sat, 16 Jan 2016 15:07:04 +0800 > From: Fangwen Yu > > With DejaVu Sans Mono-11, text lines in Emacs are 1 pixel taller than in > gedit or gnome-terminal, also, bold faces are 1 pixel taller than > regular, so if the theme uses bold faces, texts will jump up and down > while editing. The line height problem also happens with Consolas font, > but the bold faces problem doesn't. > > Since it clearly has something to do with font height, I digged into the > source and found the related code. Apply this patch, and the problem is > gone: > > diff --git a/src/xftfont.c b/src/xftfont.c > index 956231e..d0f9a68 100644 > --- a/src/xftfont.c > +++ b/src/xftfont.c > @@ -395,16 +395,16 @@ xftfont_open (struct frame *f, Lisp_Object entity, int > pixel_size) > > font->ascent = xftfont->ascent; > font->descent = xftfont->descent; > - if (pixel_size >= 5) > - { > - /* The above condition is a dirty workaround because > - XftTextExtents8 behaves strangely for some fonts > - (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. */ > - if (font->ascent < extents.y) > - font->ascent = extents.y; > - if (font->descent < extents.height - extents.y) > - font->descent = extents.height - extents.y; > - } > + /* if (pixel_size >= 5) */ > + /* { */ > + /* /\* The above condition is a dirty workaround because */ > + /* XftTextExtents8 behaves strangely for some fonts */ > + /* (e.g. "Dejavu Sans Mono") when pixel_size is less than 5. *\/ */ > + /* if (font->ascent < extents.y) */ > + /* font->ascent = extents.y; */ > + /* if (font->descent < extents.height - extents.y) */ > + /* font->descent = extents.height - extents.y; */ > + /* } */ > font->height = font->ascent + font->descent; > > if (XINT (AREF (entity, FONT_SIZE_INDEX)) == 0) > > As the comment says, this piece of code is a dirty workaround, and > apparently it is causing some new problems. Thanks for the report and the patch. I'm CC'ing Handa-san, who wrote that code, in the hope that he could comment on this issue.